Re: [RFC PATCH v2 1/3] dt-bindings: mfd: rk808: add board level power hold GPIOs

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: mfd: rk808: missing dependency constraint for power-hold-gpios
--

commit d0bbedcd800c9f7a3be4e2c8731dfd10b907acc4
Author: Yaozhong Li <yaozhonguwl@gmail.com>

dt-bindings: mfd: rk808: add board level power hold GPIOs

Some boards route "power hold" lines from the SoC into the board's power
circuitry. Those lines have to be held asserted while the system is
running and released before the PMIC shutdown request is written. Add
power-hold-gpios to describe those lines and power-hold-delay-ms for
the settle time.

> diff --git a/Documentation/devicetree/bindings/mfd/rockchip,rk808.yaml b/Documentation/devicetree/bindings/mfd/rockchip,rk808.yaml
> index 50dfffac8fbf5..d59f6baf502a2 100644
> --- a/Documentation/devicetree/bindings/mfd/rockchip,rk808.yaml
> +++ b/Documentation/devicetree/bindings/mfd/rockchip,rk808.yaml

[ ... ]

> @@ -113,6 +131,9 @@ properties:
>          unevaluatedProperties: false
>      unevaluatedProperties: false
>  
> +dependencies:
> +  power-hold-delay-ms: [ power-hold-gpios ]
> +

[Severity: Low]
Does this also need a dependency constraint enforcing that power-hold-gpios
requires system-power-controller?

The documentation states it is "Only meaningful together with
system-power-controller". Without the constraint, a device tree could define
power-hold-gpios without configuring the PMIC as the system-power-controller
(or using the legacy rockchip,system-power-controller property).

This misconfiguration would silently pass schema validation but fail at runtime
because the driver ignores the GPIOs in that configuration.

>  required:
>    - compatible
>    - reg

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260919122930.1418-1-yaozhonguwl@gmail.com?part=1