Re: [PATCH 21/28] arm64: dts: apple: t8112-j413: Add speaker/headset jack nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Critical] ASoC: macaudio: hardware damage due to missing tweeter safety limits
--

commit 9fe19e1d62cebe58a30bdc3d79379ba02c88819c
Author: James Calligeros <jcalligeros99@gmail.com>

arm64: dts: apple: t8112-j413: Add speaker/headset jack nodes

The M2 MacBook Air integrates Apple-specific variants of the TI TAS2764
and Cirrus CS42L42. Add these nodes and advertise them to the machine
driver via the sound node.

> diff --git a/arch/arm64/boot/dts/apple/t8112-j413.dts b/arch/arm64/boot/dts/apple/t8112-j413.dts
> index 7ccfceb080930..38d0e33c701c5 100644
> --- a/arch/arm64/boot/dts/apple/t8112-j413.dts
> +++ b/arch/arm64/boot/dts/apple/t8112-j413.dts
> @@ -92,4 +92,105 @@ &fpwm1 {
[ ... ]
> +	speaker_right_tweet: codec@3c {
> +		compatible = "ti,sn012776", "ti,tas2764";
> +		reg = <0x3c>;
> +		interrupts-extended = <&pinctrl_ap 11 IRQ_TYPE_LEVEL_LOW>;
> +		shutdown-gpios = <&pinctrl_ap 88 GPIO_ACTIVE_HIGH>;
> +		#sound-dai-cells = <0>;
> +		sound-name-prefix = "Right Tweet";

[Severity: Critical]
Does this prefix bypass the mandatory safety limits for the right tweeter?

The machine driver configures an 800 Hz high-pass filter and a -20dB volume
limit by passing the "* Tweeter " wildcard pattern to macaudio_set_speaker():

sound/soc/apple/macaudio.c:macaudio_fixup_controls() {
	...
	CHECK(macaudio_set_speaker, "* Tweeter ", true, 0);
	...
}

Since the left tweeter is named "Left Tweeter", the wildcard match returns 1
hit. The driver checks for a minimum of 1 hit, so it does not report an error
and the probe succeeds.

However, "Right Tweet" will silently fail to match the "* Tweeter " pattern,
leaving its controls unconfigured.

Could this lead to physical hardware damage by allowing unfiltered,
full-amplitude bass frequencies to reach the right tweeter during playback?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260920-macaudio-v1-0-741cc20a74e5@gmail.com?part=21