Re: [PATCH 17/28] arm64: dts: apple: t8103-j274: Add speaker/headset jack nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 5 potential issue(s) to consider:
- [Medium] dts: missing required regulators in cs42l83 node
- [Low] dts: duplicate &i2c2 node definition
- [Low] dts: invalid compatible string array for tas2770
- [Low] dts: undocumented properties in cs42l83 node
- [Low] dts: missing addressing properties in sound node
--

commit 05517f4fbd6ba283bbb6aac224c8afd505d5bf52
Author: James Calligeros <jcalligeros99@gmail.com>
arm64: dts: apple: t8103-j274: Add speaker/headset jack nodes

This commit introduces speaker and headset jack nodes for the M1 Mac mini. 
It defines configurations for the TI TAS2770 and Cirrus CS42L42 audio 
codecs and links them to the machine driver.

> diff --git a/arch/arm64/boot/dts/apple/t8103-j274.dts b/arch/arm64/boot/dts/apple/t8103-j274.dts
> index 1212852251e07..4b30f08eaac01 100644
> --- a/arch/arm64/boot/dts/apple/t8103-j274.dts
> +++ b/arch/arm64/boot/dts/apple/t8103-j274.dts
[ ... ]
> +/* Audio codecs */
> +&i2c1 {
> +	status = "okay";
> +
> +	speaker: codec@31 {
> +		compatible = "ti,tas5770l", "ti,tas2770";

[Severity: Low]
Will this compatible string array fail schema validation? 

The ti,tas2770.yaml schema restricts the compatible property to a single enum
of either "ti,tas2770" or "ti,tas5770l". Providing an array instead of a 
single string causes a dtbs_check validation error.

> +		reg = <0x31>;
> +		interrupts-extended = <&pinctrl_ap 182 IRQ_TYPE_LEVEL_LOW>;
> +		shutdown-gpios = <&pinctrl_ap 181 GPIO_ACTIVE_HIGH>;
> +		#sound-dai-cells = <0>;
> +		ti,imon-slot-no = <0>;
> +		ti,vmon-slot-no = <2>;
> +	};
> +};
> +
> +&i2c2 {
> +	status = "okay";
> +
> +	jack_codec: codec@48 {

[Severity: Low]
Is there a reason to redefine &i2c2 here?

The t8103-j274.dts file already contains an &i2c2 block earlier in the file. 
Appending another &i2c2 block at the end of the file is redundant; the 
jack_codec child could be added directly to the existing &i2c2 block.

[Severity: Medium]
Are there missing regulator supplies for this codec?

The cirrus,cs42l42.yaml binding explicitly requires VP-supply, VCP-supply, 
VD_FILT-supply, VL-supply, and VA-supply. These are absent from this node, 
which can lead to schema validation failures and driver probe failures if 
dummy regulators are disabled.

> +		compatible = "cirrus,cs42l83";
> +		reg = <0x48>;
> +		interrupts-extended = <&pinctrl_ap 183 IRQ_TYPE_LEVEL_LOW>;
> +		reset-gpios = <&pinctrl_nub 11 GPIO_ACTIVE_HIGH>;
> +		#sound-dai-cells = <0>;
> +		sound-name-prefix = "Jack";

[Severity: Low]
Do these generic audio properties pass schema checks?

The cirrus,cs42l42.yaml binding specifies `additionalProperties: false` but 
does not include #sound-dai-cells or sound-name-prefix, nor does it include 
a reference to dai-common.yaml. Their presence will trigger validation errors.

> +		cirrus,ts-inv = <1>;
> +	};
> +};
> +
> +/ {
> +	sound: sound {
> +		compatible = "apple,j274-macaudio", "apple,macaudio";
> +		model = "Mac mini J274";

[Severity: Low]
Should this parent node declare #address-cells and #size-cells?

Since the children dai-link nodes use unit addresses, standard DT syntax and 
the apple,macaudio.yaml binding require the parent sound node to specify 
these properties to avoid compiler warnings.

> +
> +		dai-link@0 {

[Severity: Low]
Does this node require a reg property?

Using a unit address without a matching reg property violates device tree 
specification and causes compiler warnings.

> +			link-name = "Speaker";
> +
> +			codec {
> +				sound-dai = <&speaker>;
> +			};
> +
> +			cpu {
> +				sound-dai = <&mca 0>;
> +			};
> +		};
> +
> +		dai-link@1 {

[Severity: Low]
Similarly, does this dai-link need a reg property to match the @1 unit 
address?

> +			link-name = "Headphone Jack";
> +
> +			codec {
> +				sound-dai = <&jack_codec>;
> +			};
> +
> +			cpu {
> +				sound-dai = <&mca 2>;
> +			};
> +		};
> +	};
> +};
> +
>  #include "hwmon-mini.dtsi"

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260920-macaudio-v1-0-741cc20a74e5@gmail.com?part=17