Re: [PATCH 2/2] dt-bindings: usb: qcom,pmic-types: make example use generic VBUS property

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: incomplete oneOf constraint allows omitting VBUS supply
--

commit 3178bc24ea3cc08021dfdd40f7987789b23a49de
Author: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

dt-bindings: usb: qcom,pmic-types: make example use generic VBUS property

The commit fe2195b019f6 ("dt-bindings: usb: qcom,pmic-typec: deprecate
device-specific VBUS") switched the schema to use generic vbus-supply
property, however the example continued to use the old, deprecated one.
Update example to use the expected style of specifying the VBUS.

> diff --git a/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml b/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml
> index db487562cec49..dd56dc8afe032 100644
> --- a/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml
> +++ b/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml
> @@ -176,7 +176,6 @@ examples:
[ ... ]
> -            vdd-vbus-supply = <&pm8150b_vbus>;
>              vdd-pdphy-supply = <&vreg_l2a_3p1>;
>  
>              connector {
> @@ -186,6 +185,8 @@ examples:
>                  data-role = "dual";
>                  self-powered;
>  
> +                vbus-supply = <&pm8150b_vbus>;

[Severity: Medium]
Does the schema properly enforce that one of the VBUS sources is provided?

Looking at the oneOf constraint defined in this file:

Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml:oneOf
  - required:
      - vdd-vbus-supply
  - properties:
      connector:
        required:
          - vbus-supply

If a device tree node misses both vdd-vbus-supply and the connector node, it
fails the first branch but trivially passes the second branch. This happens
because the properties keyword only applies constraints to properties actually
present in the instance.

Since exactly one branch passes, the overall oneOf constraint evaluates to true,
silently accepting incomplete configurations and defeating the purpose of
requiring one of the VBUS sources.

Should the second branch also require the connector node to be present to
ensure the constraint works as intended?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260920-fix-tcpm-vbus-bis-v1-0-cc9347bbe81a@oss.qualcomm.com?part=2