Re: [PATCH 1/2] dt-bindings: usb: qcom,pmic-types: require one of the VBUS sources

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: broken oneOf logic erroneously rejects valid legacy nodes
--

commit 91a069f510352e4c4e88b45ca0d906bfa22ef623
Author: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

dt-bindings: usb: qcom,pmic-types: require one of the VBUS sources

This commit attempts to enforce that either the generic vbus-supply inside
a connector node or the legacy vdd-vbus-supply is provided. It adds a oneOf
constraint to check for either the old property or the generic property
inside the connector node.

> diff --git a/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml b/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml
> --- a/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml
> +++ b/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml
> @@ -91,6 +91,14 @@ required:
>    - interrupts
>    - interrupt-names
>  
> +oneOf:
> +  - required:
> +      - vdd-vbus-supply
> +  - properties:
> +      connector:
> +        required:
> +          - vbus-supply

[Severity: Medium]
Does this logic mistakenly reject valid legacy nodes and allow missing vbus
supplies?

The JSON Schema properties keyword only applies constraints if the property
exists in the instance. If the connector node is omitted entirely, the
second branch of the oneOf block will vacuously evaluate to true.

If neither vbus property is present, the first branch is false, but the
second branch is true, meaning the oneOf constraint passes. This silently
allows nodes missing vbus supplies.

Conversely, if a valid legacy node provides vdd-vbus-supply but has no
connector node, both the first branch and the second branch evaluate to
true. Because oneOf strictly requires exactly one branch to be true, it
fails validation and erroneously rejects valid legacy configurations.

Should the second branch use a required constraint for the connector node to
prevent this issue?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260920-fix-tcpm-vbus-bis-v1-0-cc9347bbe81a@oss.qualcomm.com?part=1