Re: [PATCH 1/2] dt-bindings: arm: qcom,ids: add few more SOC IDs for IPQ5210 family

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] cpufreq: qcom: kernel panic on boot due to missing SoC IDs in switch case
--

commit 0b99a8e575edc333a621cdaa6e2499570c73a001
Author: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>

dt-bindings: arm: qcom,ids: add few more SOC IDs for IPQ5210 family

QCF3211 and IPQ5211 are the new SoCs based on the IPQ5210 family. Add
the SoC IDs for the same.

> diff --git a/include/dt-bindings/arm/qcom,ids.h b/include/dt-bindings/arm/qcom,ids.h
> index b63e4a0b8e545..f251d4c75612c 100644
> --- a/include/dt-bindings/arm/qcom,ids.h
> +++ b/include/dt-bindings/arm/qcom,ids.h
> @@ -317,6 +317,8 @@
>  #define QCOM_ID_IPQ9630			779
>  #define QCOM_ID_IPQ9640			780
>  #define QCOM_ID_IPQ9670			781
> +#define QCOM_ID_QCF3211			801
> +#define QCOM_ID_IPQ5211			802

[Severity: High]
Will adding these new SoC IDs cause a kernel panic during boot when using the
qcom-cpufreq-nvmem driver?

Because these new SoCs are based on the IPQ5210 family, they will likely match
the fallback compatible string in the device tree and load the driver.

During probe, the driver reads the actual SoC ID from SMEM, but these new IDs
are currently missing from the switch statement:

drivers/cpufreq/qcom-cpufreq-nvmem.c:qcom_cpufreq_kryo_name_version() {
    ...
	ret = qcom_smem_get_soc_id(&msm_id);
    ...
	switch (msm_id) {
    ...
	case QCOM_ID_IPQ5200:
	case QCOM_ID_IPQ5210:
	case QCOM_ID_QCF2200:
	case QCOM_ID_QCF3200:
	case QCOM_ID_QCF3210:
		drv->versions = (*speedbin == 0xcd) ? BIT(1) : BIT(0);
		break;
    ...
	default:
		BUG();
		break;
	}
    ...
}

Because QCOM_ID_QCF3211 and QCOM_ID_IPQ5211 are unhandled, execution will fall
through to the default case, triggering an unconditional BUG() and bringing
down the system during boot.

Should these new IDs be added to the IPQ5210 case block in the driver to
prevent the crash?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260921-ipq52xx_new_ids-v1-0-63d68a11bbff@oss.qualcomm.com?part=1