Re: [PATCH v3 4/6] arm: sunplus: enable SMP via PSCI on SP7021

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dts: psci method smc contradicts commit message claiming hvc
--

commit ad7995ba29a2bfb8caf59ae3e73d64961f25f162
Author: Andrew Gaylard <ag@ffroot.co.za>

arm: sunplus: enable SMP via PSCI on SP7021

This commit adds the psci node and enables SMP via PSCI on the Cortex-A7 cores
of the SP7021.

> diff --git a/arch/arm/boot/dts/sunplus/sunplus-sp7021-achip.dtsi b/arch/arm/boot/dts/sunplus/sunplus-sp7021-achip.dtsi
> index 493d32357e4eb..b73cfde7ace4d 100644
> --- a/arch/arm/boot/dts/sunplus/sunplus-sp7021-achip.dtsi
> +++ b/arch/arm/boot/dts/sunplus/sunplus-sp7021-achip.dtsi

[ ... ]

>  	};
>  
> +	psci {
> +		compatible = "arm,psci-0.2";
> +		method = "smc";

[Severity: Medium]
The commit message states that the SP7021 firmware implements PSCI 0.2 via
HVC, but the psci node configures the method as smc.

If the firmware actually requires HVC, will using SMC cause PSCI calls to trap
to the wrong exception level (EL3 instead of EL2) or trigger an undefined
instruction exception during SMP bring-up?

Could you clarify if the device tree method should be hvc, or if the commit
message needs to be updated?

> +	};
> +
>  	gic: interrupt-controller@9f101000 {

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260921182620.17597-1-ag@ffroot.co.za?part=4