Re: [PATCH v3 3/6] arm: dts: sunplus: add PWM, watchdog and MMC nodes to SP7021 DTSI

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt: board-specific MMC properties hardcoded in SoC-level .dtsi
--

commit 17776a65b44f3bc151f243f012bdb8edd8912aba
Author: Andrew Gaylard <ag@ffroot.co.za>

arm: dts: sunplus: add PWM, watchdog and MMC nodes to SP7021 DTSI

This commit adds device nodes for the PWM controller, Watchdog controller,
and eMMC controller to the SP7021 generic SoC device tree include file.
It also adds a label to the gpio-leds node to allow overrides by board files.

> diff --git a/arch/arm/boot/dts/sunplus/sunplus-sp7021.dtsi b/arch/arm/boot/dts/sunplus/sunplus-sp7021.dtsi
> index ae9bbe0320b8d..17185238e7ba7 100644
> --- a/arch/arm/boot/dts/sunplus/sunplus-sp7021.dtsi
> +++ b/arch/arm/boot/dts/sunplus/sunplus-sp7021.dtsi
[ ... ]
> +		mmc0: mmc@3b00 {
> +			compatible = "sunplus,sp7021-mmc";
> +			reg = <0x3b00 0x180>;
> +			interrupts = <20 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&clkc CLK_CARD_CTL0>;
> +			resets = <&rstc RST_CARD_CTL0>;
> +			pinctrl-names = "default";
> +			pinctrl-0 = <&emmc_pins>;
> +			bus-width = <8>;
> +			max-frequency = <52000000>;
> +			non-removable;
> +			disable-wp;
> +			cap-mmc-highspeed;
> +			mmc-ddr-3_3v;
> +			no-sdio;
> +			no-sd;

[Severity: Low]
Are these board-specific form-factor and electronic configurations appropriate
for the generic SoC-level dtsi file?

Hardcoding properties like non-removable, bus-width = <8>, no-sd, and no-sdio
in the generic SoC definition violates Device Tree design principles. If a
future board based on this SoC routes the mmc0 controller differently, such
as to a removable SD card slot, it will inherit these inappropriate properties.

Does this mean developers would have to use cumbersome /delete-property/
directives in their board dts files to undo the SoC-level configuration just
to make an SD card work?

> +			status = "disabled";
> +		};
>  	};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260921182620.17597-1-ag@ffroot.co.za?part=3