From: sashiko-bot@kernel.org
To: "Rob Herring (Arm)" <robh@kernel.org>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH] dt-bindings: soc: mediatek: Allow pwrap regs
Date: Mon, 21 Sep 2026 23:31:05 +0000 [thread overview]
Message-ID: <20260921233106.4B3ED1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260921232527.3127894-1-robh@kernel.org>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: missing referenced mediatek,mt6380-regulator.yaml schema
--
commit 73b0295b13e9c91b5f296071d21498bc710f649e
Author: Rob Herring (Arm) <robh@kernel.org>
dt-bindings: soc: mediatek: Allow pwrap regs
This commit updates the MT7622 PMIC wrapper binding to add a child schema
reference for regulators. This change routes regulator subnodes to the
MT6380 regulator binding for evaluation.
> diff --git a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
> --- a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
> +++ b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
> @@ -105,6 +105,9 @@ properties:
> pmic:
> type: object
>
> + regulators:
> + $ref: /schemas/regulator/mediatek,mt6380-regulator.yaml#
[Severity: Low]
Does this introduce an invalid schema reference for the regulators property?
It appears the referenced mediatek,mt6380-regulator.yaml file does not exist
in the repository, as the MT6380 regulator binding is currently a legacy text
file (mt6380-regulator.txt).
This can cause make dt_binding_check to fail when resolving the
cross-reference or silently skip validating the regulators node. Subsequent
patches in the series also do not appear to add the missing YAML file.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260921232527.3127894-1-robh@kernel.org?part=1
next prev parent reply other threads:[~2026-09-21 23:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 23:25 [PATCH] dt-bindings: soc: mediatek: Allow pwrap regs Rob Herring (Arm)
2026-09-21 23:31 ` sashiko-bot [this message]
2026-09-22 11:45 ` AngeloGioacchino Del Regno
2026-09-22 19:54 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260921233106.4B3ED1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox