Devicetree
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: soc: mediatek: Allow pwrap regs
@ 2026-09-21 23:25 Rob Herring (Arm)
  2026-09-21 23:31 ` sashiko-bot
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Rob Herring (Arm) @ 2026-09-21 23:25 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
	AngeloGioacchino Del Regno, Flora Fu, Alexandre Mergnat
  Cc: devicetree, linux-kernel, linux-arm-kernel, linux-mediatek

The MT7622 PMIC wrapper has a regulators child node. Add the child
schema reference so regulator subnodes are evaluated by the MT6380
regulator binding instead of being rejected.

Assisted-by: Codex:gpt-5-5
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 .../devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml       | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
index e7c4a3984c60..79b755858bad 100644
--- a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
+++ b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
@@ -105,6 +105,9 @@ properties:
   pmic:
     type: object
 
+  regulators:
+    $ref: /schemas/regulator/mediatek,mt6380-regulator.yaml#
+
 required:
   - compatible
   - reg
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: soc: mediatek: Allow pwrap regs
  2026-09-21 23:25 [PATCH] dt-bindings: soc: mediatek: Allow pwrap regs Rob Herring (Arm)
@ 2026-09-21 23:31 ` sashiko-bot
  2026-09-22 11:45 ` AngeloGioacchino Del Regno
  2026-09-22 19:54 ` Rob Herring
  2 siblings, 0 replies; 4+ messages in thread
From: sashiko-bot @ 2026-09-21 23:31 UTC (permalink / raw)
  To: Rob Herring (Arm); +Cc: devicetree, robh, conor+dt

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: missing referenced mediatek,mt6380-regulator.yaml schema
--

commit 73b0295b13e9c91b5f296071d21498bc710f649e
Author: Rob Herring (Arm) <robh@kernel.org>

dt-bindings: soc: mediatek: Allow pwrap regs

This commit updates the MT7622 PMIC wrapper binding to add a child schema
reference for regulators. This change routes regulator subnodes to the
MT6380 regulator binding for evaluation.

> diff --git a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
> --- a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
> +++ b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
> @@ -105,6 +105,9 @@ properties:
>    pmic:
>      type: object
>  
> +  regulators:
> +    $ref: /schemas/regulator/mediatek,mt6380-regulator.yaml#

[Severity: Low]
Does this introduce an invalid schema reference for the regulators property?

It appears the referenced mediatek,mt6380-regulator.yaml file does not exist
in the repository, as the MT6380 regulator binding is currently a legacy text
file (mt6380-regulator.txt).

This can cause make dt_binding_check to fail when resolving the
cross-reference or silently skip validating the regulators node. Subsequent
patches in the series also do not appear to add the missing YAML file.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260921232527.3127894-1-robh@kernel.org?part=1

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: soc: mediatek: Allow pwrap regs
  2026-09-21 23:25 [PATCH] dt-bindings: soc: mediatek: Allow pwrap regs Rob Herring (Arm)
  2026-09-21 23:31 ` sashiko-bot
@ 2026-09-22 11:45 ` AngeloGioacchino Del Regno
  2026-09-22 19:54 ` Rob Herring
  2 siblings, 0 replies; 4+ messages in thread
From: AngeloGioacchino Del Regno @ 2026-09-22 11:45 UTC (permalink / raw)
  To: Rob Herring (Arm), Krzysztof Kozlowski, Conor Dooley,
	Matthias Brugger, Flora Fu, Alexandre Mergnat
  Cc: devicetree, linux-kernel, linux-arm-kernel, linux-mediatek

On 9/22/26 01:25, Rob Herring (Arm) wrote:
> The MT7622 PMIC wrapper has a regulators child node. Add the child
> schema reference so regulator subnodes are evaluated by the MT6380
> regulator binding instead of being rejected.
> 
> Assisted-by: Codex:gpt-5-5
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: soc: mediatek: Allow pwrap regs
  2026-09-21 23:25 [PATCH] dt-bindings: soc: mediatek: Allow pwrap regs Rob Herring (Arm)
  2026-09-21 23:31 ` sashiko-bot
  2026-09-22 11:45 ` AngeloGioacchino Del Regno
@ 2026-09-22 19:54 ` Rob Herring
  2 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2026-09-22 19:54 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
	AngeloGioacchino Del Regno, Flora Fu, Alexandre Mergnat
  Cc: devicetree, linux-kernel, linux-arm-kernel, linux-mediatek

On Mon, Sep 21, 2026 at 06:25:26PM -0500, Rob Herring (Arm) wrote:
> The MT7622 PMIC wrapper has a regulators child node. Add the child
> schema reference so regulator subnodes are evaluated by the MT6380
> regulator binding instead of being rejected.
> 
> Assisted-by: Codex:gpt-5-5
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
>  .../devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml       | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
> index e7c4a3984c60..79b755858bad 100644
> --- a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
> +++ b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
> @@ -105,6 +105,9 @@ properties:
>    pmic:
>      type: object
>  
> +  regulators:
> +    $ref: /schemas/regulator/mediatek,mt6380-regulator.yaml#

Err, this needs the conversion. Dropping this patch.

Rob

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-09-22 19:54 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-21 23:25 [PATCH] dt-bindings: soc: mediatek: Allow pwrap regs Rob Herring (Arm)
2026-09-21 23:31 ` sashiko-bot
2026-09-22 11:45 ` AngeloGioacchino Del Regno
2026-09-22 19:54 ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox