[PATCH v2] dt-bindings: arm: vexpress: drop the obsolete hwmon and regulator text files

[PATCH v2] dt-bindings: arm: vexpress: drop the obsolete hwmon and regulator text files

[Quchaosheng]

Documentation/devicetree/bindings/hwmon/vexpress.txt describes the
arm,vexpress-volt, -amp, -temp, -power and -energy sensors, and
Documentation/devicetree/bindings/regulator/vexpress.txt describes the
arm,vexpress-volt regulator.

Both restate what arm/vexpress-config.yaml already documents: the same
compatibles, the arm,vexpress-sysreg,func property and the label property.
The regulator node refers to regulator.yaml for the generic regulator
properties.

The regulator file also lists two of them as required, regulator-name and
regulator-always-on. regulator.yaml defines both but requires neither, so
removing the file without doing anything else would quietly drop that
constraint. Add them to the regulator node's required list; all 13 in-tree
arm,vexpress-volt nodes set both.

One sentence in the regulator file is not a restatement: it says that a
supply without regulator-min-microvolt and regulator-max-microvolt is
treated as fixed. vexpress_regulator_probe() implements that by selecting
vexpress_regulator_ops_ro when the two properties do not both define a
range. Move the note into the regulator node description in the schema,
so that removing the file does not lose it.

Nothing else refers to the two files. Remove them.

Assisted-by: LLM
Signed-off-by: Quchaosheng <quchaosheng000406@163.com>
---

Changes in v2:
- Add regulator-name and regulator-always-on to the required list of the
  regulator node. The deleted text file listed both as required while
  regulator.yaml requires neither, so the constraint would have been lost
  silently. Reported by sashiko.
 .../bindings/arm/vexpress-config.yaml         |  6 ++++
 .../devicetree/bindings/hwmon/vexpress.txt    | 23 -------------
 .../bindings/regulator/vexpress.txt           | 32 -------------------
 3 files changed, 6 insertions(+), 55 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/hwmon/vexpress.txt
 delete mode 100644 Documentation/devicetree/bindings/regulator/vexpress.txt

diff --git a/Documentation/devicetree/bindings/arm/vexpress-config.yaml b/Documentation/devicetree/bindings/arm/vexpress-config.yaml
index 41c53e3acc12..8fe24a997cfd 100644
--- a/Documentation/devicetree/bindings/arm/vexpress-config.yaml
+++ b/Documentation/devicetree/bindings/arm/vexpress-config.yaml
@@ -139,6 +139,10 @@ patternProperties:
 
   "^regulator-.+$":
     $ref: /schemas/regulator/regulator.yaml#
+    description:
+      If regulator-min-microvolt and regulator-max-microvolt do not both
+      define a range, the supply is treated as fixed and only its voltage
+      can be read.
     properties:
       compatible:
         const: arm,vexpress-volt
@@ -157,6 +161,8 @@ patternProperties:
     required:
       - compatible
       - arm,vexpress-sysreg,func
+      - regulator-name
+      - regulator-always-on
 
   "^amp-.+$":
     type: object
diff --git a/Documentation/devicetree/bindings/hwmon/vexpress.txt b/Documentation/devicetree/bindings/hwmon/vexpress.txt
deleted file mode 100644
index 4a4df4ffc460..000000000000
--- a/Documentation/devicetree/bindings/hwmon/vexpress.txt
+++ /dev/null
@@ -1,23 +0,0 @@
-Versatile Express hwmon sensors
--------------------------------
-
-Requires node properties:
-- "compatible" value : one of
-	"arm,vexpress-volt"
-	"arm,vexpress-amp"
-	"arm,vexpress-temp"
-	"arm,vexpress-power"
-	"arm,vexpress-energy"
-- "arm,vexpress-sysreg,func" when controlled via vexpress-sysreg
-  (see Documentation/devicetree/bindings/arm/vexpress-config.yaml
-  for more details)
-
-Optional node properties:
-- label : string describing the monitored value
-
-Example:
-	energy@0 {
-		compatible = "arm,vexpress-energy";
-		arm,vexpress-sysreg,func = <13 0>;
-		label = "A15 Jcore";
-	};
diff --git a/Documentation/devicetree/bindings/regulator/vexpress.txt b/Documentation/devicetree/bindings/regulator/vexpress.txt
deleted file mode 100644
index 1c2e92c7831e..000000000000
--- a/Documentation/devicetree/bindings/regulator/vexpress.txt
+++ /dev/null
@@ -1,32 +0,0 @@
-Versatile Express voltage regulators
-------------------------------------
-
-Requires node properties:
-- "compatible" value: "arm,vexpress-volt"
-- "arm,vexpress-sysreg,func" when controlled via vexpress-sysreg
-  (see Documentation/devicetree/bindings/arm/vexpress-config.yaml
-  for more details)
-
-Required regulator properties:
-- "regulator-name"
-- "regulator-always-on"
-
-Optional regulator properties:
-- "regulator-min-microvolt"
-- "regulator-max-microvolt"
-
-See Documentation/devicetree/bindings/regulator/regulator.txt
-for more details about the regulator properties.
-
-When no "regulator-[min|max]-microvolt" properties are defined,
-the device is treated as fixed (or rather "read-only") regulator.
-
-Example:
-	volt@0 {
-		compatible = "arm,vexpress-volt";
-		arm,vexpress-sysreg,func = <2 0>;
-		regulator-name = "Cores";
-		regulator-min-microvolt = <800000>;
-		regulator-max-microvolt = <1050000>;
-		regulator-always-on;
-	};
-- 
2.43.0

Re: [PATCH v2] dt-bindings: arm: vexpress: drop the obsolete hwmon and regulator text files

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] docs: dangling link to deleted vexpress hwmon binding
--

commit 49de6b25b319a6b7c33aa41c9b596dc97f03cb2f
Author: Quchaosheng <quchaosheng000406@163.com>

dt-bindings: arm: vexpress: drop the obsolete hwmon and regulator text files

This commit removes the obsolete hwmon and regulator text bindings for
arm,vexpress platforms, migrating a note and required properties into the
existing vexpress-config.yaml schema.

>     One sentence in the regulator file is not a restatement: it says that a
>     supply without regulator-min-microvolt and regulator-max-microvolt is
>     treated as fixed. vexpress_regulator_probe() implements that by selecting
>     vexpress_regulator_ops_ro when the two properties do not both define a
>     range. Move the note into the regulator node description in the schema,
>     so that removing the file does not lose it.
>     
>     Nothing else refers to the two files. Remove them.

[Severity: Low]
Is this completely accurate?

Looking at Documentation/hwmon/vexpress.rst, it contains a direct reference to
the deleted hwmon binding:

Documentation/hwmon/vexpress.rst:
...
in Documentation/devicetree/bindings/hwmon/vexpress.txt.
...

Does this documentation file need to be updated to point to the yaml file
instead of becoming a dead link?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260922090836.111516-1-quchaosheng000406@163.com?part=1

Re: [PATCH v2] dt-bindings: arm: vexpress: drop the obsolete hwmon and regulator text files

[Quchaosheng]

Yes, that is right, and it is what 1/2 of this series does.

Documentation/hwmon/vexpress.rst carries that reference because nothing had
pointed it at the schema yet. Patch 1/2 replaces it with
Documentation/devicetree/bindings/arm/vexpress-config.yaml:

  https://lore.kernel.org/all/20260917115818.540344-1-quchaosheng000406@163.com/

Guenter applied 1/2 to the hwmon tree on 09-18, so the link does not dangle
once both are in. 1/2 has to land before 2/2, otherwise there is a window
where the reference points at a deleted file. That is the only ordering
constraint between the two.

I ran the grep I should have run before posting, and it confirms there is
nothing else: the reference in hwmon/vexpress.rst was the only one left in
the tree besides the two files themselves.

Quchaosheng