From: sashiko-bot@kernel.org
To: "Shawn Guo" <shengchao.guo@oss.qualcomm.com>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: nord: Add LLCC node
Date: Tue, 22 Sep 2026 09:27:05 +0000 [thread overview]
Message-ID: <20260922092706.4505E1F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260922091735.491481-1-shengchao.guo@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dts: qcom: mismatch between DT reg addresses and commit message stride
--
commit 0675a08212d643f9f31ddc67dcf4a44b377036e9
Author: Anurag Pateriya <anurag.pateriya@oss.qualcomm.com>
arm64: dts: qcom: nord: Add LLCC node
This commit adds the system cache controller to the Nord device tree. It
defines sixteen banks across four DDR slices, along with the global broadcast
regions.
> diff --git a/arch/arm64/boot/dts/qcom/nord.dtsi b/arch/arm64/boot/dts/qcom/nord.dtsi
> index e0496fd40c308..6896bda14ef3c 100644
> --- a/arch/arm64/boot/dts/qcom/nord.dtsi
> +++ b/arch/arm64/boot/dts/qcom/nord.dtsi
[ ... ]
> @@ -2071,6 +2071,46 @@ watchdog@17826000 {
> clocks = <&sleep_clk>;
> interrupts = <GIC_ESPI 848 IRQ_TYPE_EDGE_RISING>;
> };
> +
> + llcc: system-cache-controller@21800000 {
> + compatible = "qcom,nord-llcc";
> + reg = <0x0 0x21800000 0x0 0x100000>,
> + <0x0 0x21a00000 0x0 0x100000>,
> + <0x0 0x21c00000 0x0 0x100000>,
> + <0x0 0x21e00000 0x0 0x100000>,
[Severity: Medium]
The commit message states the LLCC banks are placed at 0x100000 strides, but
the bank addresses here show a 0x200000 stride (e.g., 0x21a00000 - 0x21800000
equals 0x200000). Could there be a typo in the commit message, or should these
physical addresses use a 0x100000 stride?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260922091735.491481-1-shengchao.guo@oss.qualcomm.com?part=1
next prev parent reply other threads:[~2026-09-22 9:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-22 9:17 [PATCH] arm64: dts: qcom: nord: Add LLCC node Shawn Guo
2026-09-22 9:27 ` sashiko-bot [this message]
2026-09-23 7:08 ` Bartosz Golaszewski
2026-09-23 9:08 ` Pankaj Patil
2026-09-24 11:28 ` Abel Vesa
2026-09-25 12:14 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260922092706.4505E1F00893@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=shengchao.guo@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox