Re: [PATCH] dt-bindings: pinctrl: samsung: Require clocks for Exynos9610 pinctrl nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: unconditional clock requirement breaks PINCTRL_TOP node
--

commit 8b1ed6a89af0afe8c1009cac2d735ea6bee6ec4b
Author: Alexandru Chimac <alex@chimac.ro>

dt-bindings: pinctrl: samsung: Require clocks for Exynos9610 pinctrl nodes

This commit updates the Samsung pinctrl bindings to require clocks for nodes
using the Exynos9610 compatible string, as most of these controllers have
designated clocks.

> diff --git a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml
> index 1feb6a6fc6908..e4fdedb29631b 100644
> --- a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml
> @@ -140,6 +140,7 @@ allOf:
>              enum:
>                - google,gs101-pinctrl
>                - samsung,exynos8890-pinctrl
> +              - samsung,exynos9610-pinctrl
>      then:
>        required:
>          - clocks

[Severity: Medium]
Will this unconditional requirement break schema validation for the clockless
PINCTRL_TOP node?

The commit message explicitly acknowledges that the PINCTRL_TOP node does not
have clocks. Since all Exynos9610 pin controllers share the same compatible
string, applying an unconditional required rule for clocks causes a structurally
correct PINCTRL_TOP device tree node to fail dtbs_check validation.

Could the schema be adjusted so that clocks are allowed but not universally
required for this compatible string?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260922-exynos9610-pinctrl-patch-v1-1-f6d816696591@chimac.ro?part=1