Re: [PATCH] dt-bindings: pinctrl: samsung: Require clocks for Exynos9610 pinctrl nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: pinctrl: over-constraint on exynos9610 clocks
--

commit 16b59636da37f1324cb6823b4e5fa7ff00df75fb
Author: Alexandru Chimac <alex@chimac.ro>
Subject: dt-bindings: pinctrl: samsung: Require clocks for Exynos9610 pinctrl nodes

This commit modifies the Samsung pinctrl devicetree binding to require
clocks for Exynos9610 pin controllers. It adds the Exynos9610 compatible
string to an existing conditional block that mandates clock properties.

> diff --git a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml
> index 1feb6a6fc6908..e4fdedb29631b 100644
> --- a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml
> @@ -140,6 +140,7 @@ allOf:
>              enum:
>                - google,gs101-pinctrl
>                - samsung,exynos8890-pinctrl
> +              - samsung,exynos9610-pinctrl
>      then:
>        required:
>          - clocks

[Severity: Low]
Will this cause schema validation errors for the PINCTRL_TOP node?

The commit message notes that PINCTRL_TOP does not have a clock, but adding
the compatible string to this allOf if-then conditional block enforces that
all Exynos9610 pinctrl nodes must have the clocks and clock-names properties.

Since all pin controller blocks on this SoC (including TOP) share the same
samsung,exynos9610-pinctrl compatible string, this seems to over-constrain
the binding and would cause dtbs_check to fail for PINCTRL_TOP. 

Should samsung,exynos9610-pinctrl instead be exempted from the else block
(which sets clocks: false) without moving it into this then block where
clocks are strictly required?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260922-exynos9610-pinctrl-patch-v1-1-26d8108c1802@chimac.ro?part=1