Re: [PATCH 4/4] arm64: dts: qcom: hawi: Add base MTP board

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] dt: empty endpoint with commented-out remote-endpoint in pmic_glink_dp_out
- [Low] dt: use of deprecated 'gpio' property instead of 'gpios' in fixed regulator
--

commit 4899e77f8239c42c43d695808f8c3db4831e0a93
Author: Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>

arm64: dts: qcom: hawi: Add base MTP board
    
This commit adds initial support for the Qualcomm Hawi MTP board. It enables
several base subsystems including PCIe, SD Card, UFS, USB, remoteproc, and
the UART console.

> diff --git a/arch/arm64/boot/dts/qcom/hawi-mtp.dts b/arch/arm64/boot/dts/qcom/hawi-mtp.dts
> new file mode 100644
> index 0000000000000..7709582491f9d
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/hawi-mtp.dts
[ ... ]
> +			ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
[ ... ]
> +				port@2 {
> +					reg = <2>;
> +
> +					pmic_glink_dp_out: endpoint {
> +						//remote-endpoint = <&usb_dp_qmpphy_dp_in>;
> +					};
> +				};

[Severity: Low]
Is this empty endpoint intentional? The remote-endpoint property is commented
out here in pmic_glink_dp_out, which leaves a dangling endpoint and might
violate OF graph schema requirements.

> +			};
> +		};
> +	};
> +
> +	sdcard_vdd_3p0: sdcard-vdd-3p0 {
> +		compatible = "regulator-fixed";
> +
> +		regulator-name = "sdc-vdd123";
> +		regulator-min-microvolt = <3000000>;
> +		regulator-max-microvolt = <3000000>;
> +		regulator-enable-ramp-delay = <1500>;
> +
> +		gpio = <&pmh0104_c_e0_gpios 5 GPIO_ACTIVE_HIGH>;

[Severity: Low]
Should this use the gpios property instead of gpio? The gpio property is
deprecated for fixed regulators, and using it might trigger dtbs_check
schema compliance warnings.

> +		enable-active-high;
> +
> +		pinctrl-0 = <&sd_card_eldo_en>;
> +		pinctrl-names = "default";
> +
> +		vin-supply = <&vreg_bob1>;
> +	};
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260923-hawi-dt-post-v1-0-e41473b6298b@oss.qualcomm.com?part=4