Re: [PATCH 1/2] dt-bindings: spi: mediatek: add mediatek,spi-ipm-v59 compatible

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: spi: mediatek: placeholder mediatek,mtxxxx-spi used
--

commit fada8f8666ea668750d2860cbb190b105cbf5cde
Author: Tim Kuo <Tim.Kuo@mediatek.com>

dt-bindings: spi: mediatek: add mediatek,spi-ipm-v59 compatible

This commit adds a new compatible string "mediatek,spi-ipm-v59" for the IPM
v59 SPI IP, as it needs its own fallback compatible rather than reusing the
earlier "mediatek,spi-ipm" design.

> diff --git a/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml b/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
> --- a/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
> +++ b/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
> @@ -39,6 +39,10 @@ properties:
>                - mediatek,mt7988-spi-single
>                - mediatek,mt8188-spi-ipm
>            - const: mediatek,spi-ipm
> +      - items:
> +          - enum:
> +              - mediatek,mtxxxx-spi

[Severity: Medium]
Is "mediatek,mtxxxx-spi" meant to be replaced with a concrete SoC name?

Device tree bindings must document the actual hardware SoC variants. In
properties.compatible, this placeholder will cause actual device tree files
using the real SoC compatible string alongside the "mediatek,spi-ipm-v59"
fallback to fail dtbs_check validation, while incorrectly passing the
meaningless "mtxxxx" placeholder.

> +          - const: mediatek,spi-ipm-v59

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260924031211.2199921-1-Tim.Kuo@mediatek.com?part=1