Re: [PATCH v3 4/4] arm64: dts: mediatek: add Genio 520-EVK board

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] build: missing mt8189 dt-binding headers causes build failure
--

commit 89127654e38899b1e36f59aefa3964e9801b30af
Author: Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>

arm64: dts: mediatek: add Genio 520-EVK board

This commit adds the device tree for the Genio 520-EVK board based on the
MT8371 SoC. It provides basic hardware enablement and registers the new
board in the mediatek device tree Makefile.

> diff --git a/arch/arm64/boot/dts/mediatek/mt8371-genio-520-evk.dts b/arch/arm64/boot/dts/mediatek/mt8371-genio-520-evk.dts
> new file mode 100644
> index 0000000000000..b4fd343bc08a6
> --- /dev/null
> +++ b/arch/arm64/boot/dts/mediatek/mt8371-genio-520-evk.dts
> @@ -0,0 +1,32 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +/*
> + * Copyright (c) 2025 Collabora Ltd.
> + * Author: Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>
> + */
> +/dts-v1/;
> +
> +#include "mt8189.dtsi"
> +#include "mt8391-genio-common.dtsi"

[Severity: Low]
Does this commit rely on dt-binding headers that haven't been included in the
tree yet?

When compiling the device tree, the preprocessor fails because mt8189.dtsi
attempts to include <dt-bindings/clock/mediatek,mt8189-clk.h>, and
mt8391-genio-common.dtsi attempts to include "mt8189-pinfunc.h". Both of
these headers appear to be missing.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260924-add-mediatek-genio-520-720-evk-v3-0-2ec5c80677d4@collabora.com?part=4