Re: [PATCH v3 3/4] arm64: dts: mediatek: add Genio 720-EVK board

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] dts: incorrect mmc1 cd-gpios active polarity
- [Low] build: missing dt-binding header files
--

commit 333fee68bbe7dfc450967c253534e7bdd3fb61f2
Author: Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>
arm64: dts: mediatek: add Genio 720-EVK board

This commit adds support for the MediaTek MT8189 SoC and its variants.
It also introduces the devicetree for the Genio 720-EVK board based on
the MT8391 SoC variant.

> diff --git a/arch/arm64/boot/dts/mediatek/mt8189.dtsi b/arch/arm64/boot/dts/mediatek/mt8189.dtsi
> new file mode 100644
> index 0000000000000..b64882a931519
> --- /dev/null
> +++ b/arch/arm64/boot/dts/mediatek/mt8189.dtsi
> @@ -0,0 +1,1009 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +/*
> + * Copyright (c) 2025 MediaTek Inc.
> + *
> + * Copyright (c) 2025 Collabora Ltd.
> + * Author: Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>
> + */
> +
> +#include <dt-bindings/clock/mediatek,mt8189-clk.h>

[Severity: Low]
Does this include reference a missing dt-binding header file? This is
currently absent from the tree, which will cause a preprocessor error during
device tree compilation.

[ ... ]

> diff --git a/arch/arm64/boot/dts/mediatek/mt8391-genio-common.dtsi b/arch/arm64/boot/dts/mediatek/mt8391-genio-common.dtsi
> new file mode 100644
> index 0000000000000..00c9f3c078f5e
> --- /dev/null
> +++ b/arch/arm64/boot/dts/mediatek/mt8391-genio-common.dtsi
> @@ -0,0 +1,798 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +/*
> + * Copyright (c) 2025 Collabora Ltd.
> + * Author: Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>
> + */
> +
> +#include "mt6365.dtsi"
> +
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/input/input.h>
> +#include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/leds/common.h>
> +#include <dt-bindings/spmi/spmi.h>
> +#include "mt8189-pinfunc.h"

[Severity: Low]
Does this reference a missing pin configuration header file? Similar to the
clock header above, this file appears to be missing and will cause the
compilation step to fail.

[ ... ]

> +&mmc1 {
> +	bus-width = <4>;
> +	cap-sd-highspeed;
> +	cd-gpios = <&pio 2 GPIO_ACTIVE_HIGH>;

[Severity: Medium]
Is GPIO_ACTIVE_HIGH the intended polarity for this card detect pin?

Further down in this file, the mmc1_default_pins block configures this
physical pin with a pull-up resistor:

	mmc1_default_pins: mmc1-default-pins {
		...
		pins-insert {
			pinmux = <PINMUX_GPIO2__FUNC_GPIO2>;
			bias-pull-up;
		};
	};

This pull-up implies the empty slot state is HIGH, and card insertion shorts
it to LOW. If the active state is declared as GPIO_ACTIVE_HIGH, will the mmc
core incorrectly interpret an empty slot as having a card inserted, and an
inserted card as being removed? Should this be GPIO_ACTIVE_LOW instead?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260924-add-mediatek-genio-520-720-evk-v3-0-2ec5c80677d4@collabora.com?part=3