From: sashiko-bot@kernel.org
To: "Shawn Guo" <shengchao.guo@oss.qualcomm.com>
Cc: devicetree@vger.kernel.org, conor+dt@kernel.org, robh@kernel.org
Subject: Re: [PATCH v2] arm64: dts: qcom: nord: Add adreno SMMU nodes
Date: Thu, 24 Sep 2026 08:53:57 +0000 [thread overview]
Message-ID: <20260924085358.4F81D1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260924084805.1021758-1-shengchao.guo@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dts: missing nord-embedded.dtsi changes for adreno SMMU nodes
--
commit a2c0ee3a850e499db0187f8a73a66cb5ce9ccf9c
Author: Bibek Kumar Patro <bibek.patro@oss.qualcomm.com>
arm64: dts: qcom: nord: Add adreno SMMU nodes
Add the Adreno GPU SMMMUs (MMU-500) for both GPU instances.
> diff --git a/arch/arm64/boot/dts/qcom/nord.dtsi b/arch/arm64/boot/dts/qcom/nord.dtsi
> index e0496fd40c308..376ae16041752 100644
> --- a/arch/arm64/boot/dts/qcom/nord.dtsi
> +++ b/arch/arm64/boot/dts/qcom/nord.dtsi
> @@ -1518,6 +1518,80 @@ tcsr: syscon@1f60000 {
> reg = <0x0 0x01f60000 0x0 0xa0000>;
> };
>
> + adreno_smmu_0: iommu@3da0000 {
> + compatible = "qcom,nord-smmu-500",
> + "qcom,adreno-smmu",
> + "qcom,smmu-500",
> + "arm,mmu-500";
> + reg = <0x0 0x03da0000 0x0 0x40000>;
[Severity: Medium]
The commit message states that the gpucc clock and power domain are wired up
in nord-embedded.dtsi for these adreno SMMU nodes.
However, this patch only modifies nord.dtsi and omits the intended changes
to nord-embedded.dtsi. When probing the adreno SMMU on embedded Nord variants
that rely on gpucc, are the clock and power domain properties missing for
adreno_smmu_0 in arch/arm64/boot/dts/qcom/nord.dtsi?
Could this lead to driver probe failures or hardware aborts?
[ ... ]
> + adreno_smmu_1: iommu@98a0000 {
> + compatible = "qcom,nord-smmu-500",
[Severity: Medium]
Similarly, when probing adreno_smmu_1 in arch/arm64/boot/dts/qcom/nord.dtsi,
is this base node also missing the clock and power domain properties that
were intended to be specified in nord-embedded.dtsi?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260924084805.1021758-1-shengchao.guo@oss.qualcomm.com?part=1
next prev parent reply other threads:[~2026-09-24 8:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-24 8:48 [PATCH v2] arm64: dts: qcom: nord: Add adreno SMMU nodes Shawn Guo
2026-09-24 8:53 ` sashiko-bot [this message]
2026-09-24 9:54 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260924085358.4F81D1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=shengchao.guo@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox