Re: [PATCH v1 4/7] ARM: tegra: lg-x3: Add light sensor node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt: incorrect interrupt polarity for apds9900 sensor
--

commit 373b2db230a91414c156f1ebbe3d13fb896ef4ef
Author: Svyatoslav Ryhel <clamor95@gmail.com>

ARM: tegra: lg-x3: Add light sensor node

This commit adds a device tree node for the Avago APDS9900 ambient light
and proximity sensor to the Tegra30 LG X3 device tree.

> diff --git a/arch/arm/boot/dts/nvidia/tegra30-lg-x3.dtsi b/arch/arm/boot/dts/nvidia/tegra30-lg-x3.dtsi
> index 9e720512e7962..74583eb07aa84 100644
> --- a/arch/arm/boot/dts/nvidia/tegra30-lg-x3.dtsi
> +++ b/arch/arm/boot/dts/nvidia/tegra30-lg-x3.dtsi
[ ... ]
> @@ -1106,6 +1106,19 @@ nfc@28 {
>  			firmware-gpios = <&gpio TEGRA_GPIO(R, 0) GPIO_ACTIVE_HIGH>;
>  		};
>  
> +		light-sensor@39 {
> +			compatible = "avago,apds9900";
> +			reg = <0x39>;
> +
> +			interrupt-parent = <&gpio>;
> +			interrupts = <TEGRA_GPIO(K, 2) IRQ_TYPE_EDGE_RISING>;

[Severity: Medium]
Is the interrupt trigger type correct for this sensor?

The interrupt trigger type is defined as a rising edge, which appears to
conflict with the active-low (falling edge) hardware signal and driver
expectations. 

The tsl2772 driver expects to use IRQF_TRIGGER_FALLING when it calls
devm_request_threaded_irq() during probe.

Could this mismatch cause the sensor's interrupt request to fail during probe,
or cause the interrupt to trigger on the wrong edge and miss events?

> +
> +			vdd-supply = <&vdd_3v0_proxi>;
> +			vddio-supply = <&vdd_1v8_sen>;
> +
> +			led-max-microamp = <100000>;
> +		};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260924090608.28734-1-clamor95@gmail.com?part=4