Re: [PATCH v1 5/7] ARM: tegra: lg-x3: Add flash LEDs controller node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dts: hw misrepresentation of single flash LED as multiple nodes
--

commit 1c030c2896d9a641e8c683129fc55fbf9766228a
Author: Svyatoslav Ryhel <clamor95@gmail.com>
ARM: tegra: lg-x3: Add flash LEDs controller node

This commit adds a device tree node for the ti lm3559 controller used for
flash leds on the tegra30 lg-x3 device. It configures the controller and
sets up two separate child nodes to represent the flash.

> diff --git a/arch/arm/boot/dts/nvidia/tegra30-lg-x3.dtsi b/arch/arm/boot/dts/nvidia/tegra30-lg-x3.dtsi
> index 74583eb07aa84..14d4f992222c6 100644
> --- a/arch/arm/boot/dts/nvidia/tegra30-lg-x3.dtsi
> +++ b/arch/arm/boot/dts/nvidia/tegra30-lg-x3.dtsi
[ ... ]
> @@ -1267,6 +1268,35 @@ m24c08: eeprom@50 {
[ ... ]
> +		led-controller@53 {
> +			compatible = "ti,lm3559";
> +			reg = <0x53>;
[ ... ]
> +			/* single flash led is on 2 lines */
> +			lm3559_led0: led@0 {
> +				reg = <0>;
> +
> +				flash-max-microamp = <393750>;
> +				led-max-microamp = <140625>;
> +			};
> +
> +			lm3559_led1: led@1 {
> +				reg = <1>;

[Severity: Medium]
Does this configuration incorrectly define a single physical led as two
independent led devices?

The comment indicates the single flash led is on two lines, but splitting it
into two separate nodes exposes two distinct video4linux2 subdevices. Device
trees generally describe hardware topology rather than driver limitations.

Should this be modeled as a single node using a property like
led-sources = <0 1>? Even if the current driver lacks support for the
led-sources property, duplicating child nodes to work around driver
limitations is considered a device tree anti-pattern.

> +
> +				flash-max-microamp = <393750>;
> +				led-max-microamp = <140625>;
> +			};
> +		};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260924090608.28734-1-clamor95@gmail.com?part=5