Re: [PATCH v3 2/2] arm64: dts: qcom: nord: wire up GPI DMA for QUP I2C/SPI engines

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dts: qcom: incorrect SPI DMA properties assigned to UART nodes
--

commit a079d3bb22e267f160ba116fb91e4d6d5467e84e
Author: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>

arm64: dts: qcom: nord: wire up GPI DMA for QUP I2C/SPI engines

This commit adds DMA phandles to I2C and SPI QUPv3 serial engine nodes in
the nord device tree.

> diff --git a/arch/arm64/boot/dts/qcom/nord.dtsi b/arch/arm64/boot/dts/qcom/nord.dtsi
> index bc48238050ecc..0ce5db7479199 100644
> --- a/arch/arm64/boot/dts/qcom/nord.dtsi
> +++ b/arch/arm64/boot/dts/qcom/nord.dtsi
[ ... ]
> @@ -1182,6 +1218,10 @@ uart0: serial@980000 {
>  				reg = <0x0 0x00980000 0x0 0x4000>;
>  				interrupts = <GIC_SPI 314 IRQ_TYPE_LEVEL_HIGH>;
>  
> +				dmas = <&gpi_dma0 0 0 QCOM_GPI_SPI>,
> +				       <&gpi_dma0 1 0 QCOM_GPI_SPI>;

[Severity: Medium]
Is this SPI DMA configuration mistakenly applied to the UART node instead
of spi0?

The intended SPI node appears to be left without DMA support, which could
cause it to fall back to PIO mode or fail to initialize if DMA is strictly
required by a driver. Additionally, giving the UART node a DMA configuration
using the SPI protocol identifier (QCOM_GPI_SPI) might cause initialization
to fail or malfunction if a board enables uart0 and attempts to request these
DMA channels.

This same pattern appears to occur in the DMA additions for uart1, uart2,
uart3, uart7, uart8, uart11, and uart12 later in this file.

> +				dma-names = "tx", "rx";
> +
>  				status = "disabled";
>  			};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260924-nord-gpi-dts-v3-0-74a85134699f@oss.qualcomm.com?part=2