From: sashiko-bot@kernel.org
To: "Nihal Kumar Gupta" <nihal.gupta@oss.qualcomm.com>
Cc: vkoul@kernel.org, neil.armstrong@linaro.org, olteanv@gmail.com,
devicetree@vger.kernel.org, linux-phy@lists.infradead.org,
conor+dt@kernel.org, media-ci@linuxtv.org, robh@kernel.org
Subject: Re: [PATCH v4 2/3] dt-bindings: media: qcom,glymur-camss: Add Glymur CAMSS
Date: Fri, 25 Sep 2026 05:58:37 +0000 [thread overview]
Message-ID: <20260925055837.EEBB61F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260925-glymur_camss-v4-2-d7c2983d6d7b@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: validation failure due to missing phy@ child nodes and cell properties
--
commit 2c100de42ea1bb8c2267da0512e16ed0f56b5334
Author: Nihal Kumar Gupta <nihal.gupta@oss.qualcomm.com>
dt-bindings: media: qcom,glymur-camss: Add Glymur CAMSS
This commit introduces the device tree binding for the Qualcomm Glymur Camera
Subsystem (CAMSS). It specifies the required resources and ports. The commit
message indicates that Glymur uses the new PHY API via standalone phy@ child
nodes.
> diff --git a/Documentation/devicetree/bindings/media/qcom,glymur-camss.yaml b/Documentation/devicetree/bindings/media/qcom,glymur-camss.yaml
> new file mode 100644
> index 0000000000000..a0b77edc21231
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/qcom,glymur-camss.yaml
[ ... ]
> +required:
> + - compatible
> + - reg
> + - reg-names
> + - clocks
> + - clock-names
> + - interrupts
> + - interrupt-names
> + - interconnects
> + - interconnect-names
> + - iommus
> + - power-domains
> + - power-domain-names
> + - ports
> +
> +additionalProperties: false
[Severity: Medium]
The commit message mentions that Glymur uses the new PHY API via standalone
phy@ child nodes. Since additionalProperties is set to false here, and there
are no definitions for phy@ child nodes or their associated properties like
#address-cells, #size-cells, or ranges, will this cause dt-validate to reject
device trees that implement these child nodes?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260925-glymur_camss-v4-0-d7c2983d6d7b@oss.qualcomm.com?part=2
next prev parent reply other threads:[~2026-09-25 5:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-25 5:48 [PATCH v4 0/3] Add CAMSS support for Qualcomm Glymur Nihal Kumar Gupta
2026-09-25 5:48 ` [PATCH v4 1/3] dt-bindings: phy: qcom,x1e80100-csi2-phy: Add Glymur compatible Nihal Kumar Gupta
2026-09-25 5:48 ` [PATCH v4 2/3] dt-bindings: media: qcom,glymur-camss: Add Glymur CAMSS Nihal Kumar Gupta
2026-09-25 5:58 ` sashiko-bot [this message]
2026-09-25 6:12 ` Nihal Kumar Gupta
2026-09-25 5:48 ` [PATCH v4 3/3] media: qcom: camss: Add Glymur compatible Nihal Kumar Gupta
2026-09-25 6:01 ` sashiko-bot
2026-09-25 6:16 ` Nihal Kumar Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260925055837.EEBB61F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=media-ci@linuxtv.org \
--cc=neil.armstrong@linaro.org \
--cc=nihal.gupta@oss.qualcomm.com \
--cc=olteanv@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox