Devicetree
 help / color / mirror / Atom feed
From: Nihal Kumar Gupta <nihal.gupta@oss.qualcomm.com>
To: sashiko-reviews@lists.linux.dev
Cc: vkoul@kernel.org, neil.armstrong@linaro.org, olteanv@gmail.com,
	devicetree@vger.kernel.org, linux-phy@lists.infradead.org,
	conor+dt@kernel.org, media-ci@linuxtv.org, robh@kernel.org
Subject: Re: [PATCH v4 2/3] dt-bindings: media: qcom,glymur-camss: Add Glymur CAMSS
Date: Fri, 25 Sep 2026 11:42:14 +0530	[thread overview]
Message-ID: <8f341b4f-fdbe-4206-a5a1-23aad375da57@oss.qualcomm.com> (raw)
In-Reply-To: <20260925055837.EEBB61F000FF@smtp.kernel.org>



On 25-09-2026 11:28, sashiko-bot@kernel.org wrote:
>> +
>> +additionalProperties: false
> [Severity: Medium]
> The commit message mentions that Glymur uses the new PHY API via standalone
> phy@ child nodes. Since additionalProperties is set to false here, and there
> are no definitions for phy@ child nodes or their associated properties like
> #address-cells, #size-cells, or ranges, will this cause dt-validate to reject
> device trees that implement these child nodes?

The phy@ nodes are standalone nodes— not children of the CAMSS node.
CAMSS connects to them via the graph framework (ports/endpoints/remote-endpoint).

The ports property is defined via $ref:/schemas/graph.yaml#/properties/ports,
so additionalProperties: false is correct and won't cause dt-validate failures.


--
Regards,
Nihal Kumar Gupta


  reply	other threads:[~2026-09-25  6:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-25  5:48 [PATCH v4 0/3] Add CAMSS support for Qualcomm Glymur Nihal Kumar Gupta
2026-09-25  5:48 ` [PATCH v4 1/3] dt-bindings: phy: qcom,x1e80100-csi2-phy: Add Glymur compatible Nihal Kumar Gupta
2026-09-25  5:48 ` [PATCH v4 2/3] dt-bindings: media: qcom,glymur-camss: Add Glymur CAMSS Nihal Kumar Gupta
2026-09-25  5:58   ` sashiko-bot
2026-09-25  6:12     ` Nihal Kumar Gupta [this message]
2026-09-25  5:48 ` [PATCH v4 3/3] media: qcom: camss: Add Glymur compatible Nihal Kumar Gupta
2026-09-25  6:01   ` sashiko-bot
2026-09-25  6:16     ` Nihal Kumar Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8f341b4f-fdbe-4206-a5a1-23aad375da57@oss.qualcomm.com \
    --to=nihal.gupta@oss.qualcomm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=media-ci@linuxtv.org \
    --cc=neil.armstrong@linaro.org \
    --cc=olteanv@gmail.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox