Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Yassine Oudjana" <y.oudjana@protonmail.com>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v9 5/6] dt-bindings: pinctrl: mediatek,mt6779-pinctrl: Add bindings for MT6735 pin controller
Date: Fri, 25 Sep 2026 15:54:35 +0000	[thread overview]
Message-ID: <20260925155436.2701F1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260925-mt6735-pinctrl-v9-v9-5-bfb19d8bb87c@protonmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] MAINTAINERS references nonexistent mt6735-pinctrl.h file
--

commit 9e8afc5717d48e9d3432a4b635154c2d3231da7e
Author: Yassine Oudjana <y.oudjana@protonmail.com>

dt-bindings: pinctrl: mediatek,mt6779-pinctrl: Add bindings for MT6735 pin controller

This commit adds device tree bindings for the MT6735 pin controller. It
updates the YAML schema and MAINTAINERS file, and introduces a new header
with pinmux definitions.

> diff --git a/MAINTAINERS b/MAINTAINERS
> index 9765e8a72dc78..3b309160440b8 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -21850,6 +21850,12 @@ F:	drivers/pinctrl/mediatek/pinctrl-rt2880.c
>  F:	drivers/pinctrl/mediatek/pinctrl-rt305x.c
>  F:	drivers/pinctrl/mediatek/pinctrl-rt3883.c
>  
> +PIN CONTROLLER - MEDIATEK MT6735
> +M:	Yassine Oudjana <y.oudjana@protonmail.com>
> +L:	linux-mediatek@lists.infradead.org (moderated for non-subscribers)
> +S:	Maintained
> +F:	include/dt-bindings/pinctrl/mediatek,mt6735-pinctrl.h

[Severity: Low]
Does this MAINTAINERS entry reference a file that does not exist?

The patch actually adds include/dt-bindings/pinctrl/mediatek,mt6735-pinfunc.h
to the tree, but this line points to mediatek,mt6735-pinctrl.h instead.

Could this cause the get_maintainer script to silently fail to match the
header file, potentially leaving the maintainer unnotified of future changes?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260925-mt6735-pinctrl-v9-v9-0-bfb19d8bb87c@protonmail.com?part=5

  reply	other threads:[~2026-09-25 15:54 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-25 15:46 [PATCH v9 0/6] MediaTek pinctrl DT binding cleanup and MT6735 pinctrl support Yassine Oudjana
2026-09-25 15:46 ` [PATCH v9 1/6] dt-bindings: pinctrl: mediatek,mt6779-pinctrl: Pull pinctrl node changes from MT6795 document Yassine Oudjana
2026-09-25 15:47 ` [PATCH v9 2/6] dt-bindings: pinctrl: mediatek,mt6779-pinctrl: Improve pinctrl subnode and property descriptions Yassine Oudjana
2026-09-25 15:47 ` [PATCH v9 3/6] dt-bindings: pinctrl: mediatek,mt6779-pinctrl: Add MT6795 Yassine Oudjana
2026-09-25 15:55   ` sashiko-bot
2026-09-25 15:47 ` [PATCH v9 4/6] dt-bindings: pinctrl: mediatek,mt6779-pinctrl: Document MT6765 pin controller Yassine Oudjana
2026-09-25 15:55   ` sashiko-bot
2026-09-25 18:42     ` Yassine Oudjana
2026-09-25 15:47 ` [PATCH v9 5/6] dt-bindings: pinctrl: mediatek,mt6779-pinctrl: Add bindings for MT6735 " Yassine Oudjana
2026-09-25 15:54   ` sashiko-bot [this message]
2026-09-25 15:48 ` [PATCH v9 6/6] pinctrl: mediatek: Add MT6735 pinctrl driver Yassine Oudjana
2026-09-25 16:09   ` sashiko-bot
2026-10-01  8:07 ` [PATCH v9 0/6] MediaTek pinctrl DT binding cleanup and MT6735 pinctrl support Linus Walleij
2026-10-06 19:29   ` Yassine Oudjana

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260925155436.2701F1F000FF@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=y.oudjana@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox