Re: [PATCH 1/8] arm64: dts: qcom: sm6350-lena: Add flash LED

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dts: stray unreferenced panel_reset_pin pinctrl node
--

commit 4da03f54d76a8976b268b2576c45e0c9edee7a57
Author: erebion <erebion@erebion.eu>

arm64: dts: qcom: sm6350-lena: Add flash LED

This commit adds a node for the camera flash LED found on the Xperia 10 III.

> diff --git a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
> index 6e2bbf4f060ac..c72ccb5544589 100644
> --- a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
> +++ b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
[ ... ]
> @@ -302,6 +304,29 @@ touchscreen@48 {
>  	};
>  };
>  
> +&pm6150l_flash {
> +	status = "okay";
> +
> +	led-0 {
> +		function = LED_FUNCTION_FLASH;
> +		color = <LED_COLOR_ID_WHITE>;
> +		led-sources = <1>;
> +		led-max-microamp = <180000>;
> +		flash-max-microamp = <1000000>;
> +		flash-max-timeout-us = <1280000>;
> +	};
> +};
> +
> +&pm6150l_gpios {
> +	panel_reset_pin: panel-reset-state {
> +		pins = "gpio9";
> +		function = "func1";
> +		power-source = <1>;
> +		bias-disable;
> +		output-low;
> +	};
> +};

[Severity: Low]
Is this panel_reset_pin pinctrl node intended to be part of this patch?

The commit message indicates this change is solely for adding the camera flash
LED, which makes this look like an accidental inclusion of an unreferenced
node that never gets applied to the hardware.

Additionally, does this correctly configure the panel reset state? It appears
to combine the hardware alternate function "func1" with the standard GPIO
"output-low" property.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260926-pdx213-upstream-3-v1-0-1609c18b5c1d@erebion.eu?part=1