Re: [PATCH 3/8] arm64: dts: qcom: sm6350-lena: Enable ADSP, CDSP & MPSS

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] arm64: dts: qcom: sm6350: mpss reg size artificially truncated
--

commit 33df29a70738e5d1e7f7a275ffc6f578951ece81
Author: erebion <erebion@erebion.eu>

arm64: dts: qcom: sm6350-lena: Enable ADSP, CDSP & MPSS

This commit enables the ADSP, CDSP, and MPSS (Modem) nodes for the Xperia 10
III. It configures the respective firmware names and updates the status of
these nodes to okay.

> diff --git a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
> --- a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
> +++ b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts

[ ... ]

> @@ -321,6 +333,13 @@ touchscreen@48 {
>  	};
>  };
>  
> +&mpss {
> +	firmware-name = "qcom/sm6350/sony/pdx213/modem.mbn";
> +	reg = <0x0 0x04080000 0x0 0x100>;

[Severity: Low]
Is this reg property artificially truncating the mpss node's MMIO region?

The reg size here is 0x100 (256 bytes), whereas the standard on-SoC mpss
node usually has a size of 0x10000 (64KB). Since the device tree describes
hardware that does not shrink across boards, could truncating this size
cause an out-of-bounds access or page fault if a future or downstream driver
attempts to ioremap and read beyond the first 256 bytes?

> +
> +	status = "okay";
> +};
> +
>  &pm6150l_flash {
>  	status = "okay";
>

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260926-pdx213-upstream-3-v1-0-1609c18b5c1d@erebion.eu?part=3