Re: [PATCH v2 13/17] arm64: dts: apple: t8122: add avd nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing DT binding documentation for apple,t8122-dart
--

commit c017f32bf6e48954134742ab315013310a3424f7
Author: Sofus Forstreuter <sofus.c@icloud.com>

arm64: dts: apple: t8122: add avd nodes

This commit adds the AVD (Apple Video Decoder) and its associated DART
IOMMU nodes to the t8122 device tree.

> diff --git a/arch/arm64/boot/dts/apple/t8122.dtsi b/arch/arm64/boot/dts/apple/t8122.dtsi
> index 1ee61c5b3409f..25e47755e0951 100644
> --- a/arch/arm64/boot/dts/apple/t8122.dtsi
> +++ b/arch/arm64/boot/dts/apple/t8122.dtsi
> @@ -186,6 +186,38 @@ soc {
>  		/* Required to get >32-bit DMA via DARTs */
>  		dma-ranges = <0 0 0 0 0xffffffff 0xffffc000>;
>  
> +		avd_dart: iommu@289010000 {
> +			compatible = "apple,t8122-dart", "apple,t8110-dart";

[Severity: Low]
Is this compatible string missing from the DT bindings schema?

Schema validation tools like dtbs_check will emit a warning because
apple,t8122-dart is not defined. While this has no runtime effect since the
kernel can safely match on the documented fallback string apple,t8110-dart,
should this string be documented in the bindings?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260926-avd-v2-0-ecebe6a3648e@icloud.com?part=13