Re: [PATCH v2 17/17] arm64: dts: apple: t6031: add avd nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dts: nodes sorted incorrectly by unit-address
--

commit fe4ebbc8c6f98e6f76243dbcfb7c2f83ad238d54
Author: Sofus Forstreuter <sofus.c@icloud.com>

arm64: dts: apple: t6031: add avd nodes

This commit adds device tree nodes for the avd dart (IOMMU) and video codec
on the Apple T6031 SoC.

> diff --git a/arch/arm64/boot/dts/apple/t6031-dieX.dtsi b/arch/arm64/boot/dts/apple/t6031-dieX.dtsi
> index 2e9d3d2e6dea4..3b21a7aae409c 100644
> --- a/arch/arm64/boot/dts/apple/t6031-dieX.dtsi
> +++ b/arch/arm64/boot/dts/apple/t6031-dieX.dtsi
> @@ -73,6 +73,38 @@ DIE_NODE(pinctrl_aop): pinctrl@2a8824000 {
>  				<AIC_IRQ DIE_NO 601 IRQ_TYPE_LEVEL_HIGH>;
>  	};
>  
> +	DIE_NODE(avd_dart): iommu@2cd010000 {

[Severity: Low]
Are these new nodes inserted in the correct order? In kernel device tree files,
nodes are conventionally sorted by unit-address.

The patch inserts iommu@2cd010000 and video-codec@2cd070000 between
pinctrl@2a8824000 and pinctrl@2b3000000. Since 0x2cd010000 and 0x2cd070000
are numerically greater than 0x2b3000000, should these new nodes be placed
after pinctrl@2b3000000 instead?

> +		compatible = "apple,t6031-dart", "apple,t8110-dart";
> +		reg = <0x2 0xcd010000 0x0 0x4000>;

[ ... ]

> +	video-codec@2cd070000 {
> +		compatible = "apple,t6031-avd", "apple,t8122-avd";

[ ... ]

>  	DIE_NODE(pinctrl_ap): pinctrl@2b3000000 {
>  		compatible = "apple,t6031-pinctrl", "apple,t8103-pinctrl";
>  		reg = <0x2 0xb3000000 0x0 0x4000>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260926-avd-v2-0-ecebe6a3648e@icloud.com?part=17