From: sashiko-bot@kernel.org
To: "Stefano Radaelli" <stefano.radaelli21@gmail.com>
Cc: imx@lists.linux.dev, robh@kernel.org, devicetree@vger.kernel.org,
conor+dt@kernel.org, Frank.Li@kernel.org
Subject: Re: [PATCH v2 10/11] ARM: dts: imx6ulz: Add Variscite i.MX6ULZ board variants
Date: Sun, 27 Sep 2026 11:06:22 +0000 [thread overview]
Message-ID: <20260927110622.A71DA1F00898@smtp.kernel.org> (raw)
In-Reply-To: <1e36d15592f904c045b7d787f26c14c5114508df.1790413032.git.stefano.r@variscite.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dts: combinatorial explosion of board permutations instead of using dt-overlays
--
commit 1ebac7e17fdd3ec057081a7015ef2c70ed9601c6
Author: Stefano Radaelli <stefano.r@variscite.com>
ARM: dts: imx6ulz: Add Variscite i.MX6ULZ board variants
Add i.MX6ULZ board DTS files for VAR-SOM-6UL and DART-6UL with their
carrier, storage, wireless and audio options.
Reuse the shared option and carrier descriptions with the i.MX6ULZ
SoC and module wrappers.
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6ulz-var-dart-emmc-sd-card-wm8731-6ulcustomboard.dts b/arch/arm/boot/dts/nxp/imx/imx6ulz-var-dart-emmc-sd-card-wm8731-6ulcustomboard.dts
> new file mode 100644
> index 0000000000000..f102909e10850
> --- /dev/null
> +++ b/arch/arm/boot/dts/nxp/imx/imx6ulz-var-dart-emmc-sd-card-wm8731-6ulcustomboard.dts
> @@ -0,0 +1,21 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Copyright (C) 2026 Variscite Ltd. - https://www.variscite.com
> + */
> +
> +/dts-v1/;
> +
> +#include "imx6ulz.dtsi"
> +#include "imx6ulz-var-dart.dtsi"
> +#include "imx6ul-imx6ull-var-dart-emmc.dtsi"
> +#include "imx6ul-imx6ull-var-wm8731.dtsi"
> +#include "imx6ulz-var-dart-6ulcustomboard.dtsi"
> +#include "imx6ul-imx6ull-var-dart-6ulcustomboard-sd-card.dtsi"
> +
> +/ {
> + model = "Variscite DART-6UL with i.MX6ULZ, eMMC, SD card & WM8731 support on VAR-6ULCustomBoard";
[Severity: Low]
Does this combinatorial explosion of board permutations create unnecessary code
complexity?
This file is one example of the 30 standalone .dts files added in this patch
that merely include a few common .dtsi files to represent every permutation of
storage, Wi-Fi, and audio options. This leads to build-time bloat and an
unmaintainable number of permutations for a single SoC.
Could this be handled instead by providing a base board .dts combined with
Device Tree Overlays (.dtso) for the optional modules, a pattern already
supported and actively used in arch/arm/boot/dts/nxp/imx/ (e.g., for dhcom and
colibri boards)?
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1790413032.git.stefano.r@variscite.com?part=10
next prev parent reply other threads:[~2026-09-27 11:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-26 11:05 [PATCH v2 00/11] ARM: dts: imx6ul: Add Variscite VAR-SOM-6UL and DART-6UL Stefano Radaelli
2026-09-26 11:05 ` [PATCH v2 01/11] dt-bindings: arm: fsl: Document Variscite i.MX6UL boards Stefano Radaelli
2026-09-26 11:05 ` [PATCH v2 02/11] dt-bindings: net: micrel: Fix RMII clock select property type Stefano Radaelli
2026-09-26 11:05 ` [PATCH v2 03/11] ARM: dts: imx6ul: Add Variscite SoM and DART base files Stefano Radaelli
2026-09-27 11:06 ` sashiko-bot
2026-09-26 11:05 ` [PATCH v2 04/11] ARM: dts: imx6ul: Add Variscite audio codec files Stefano Radaelli
2026-09-26 11:05 ` [PATCH v2 05/11] ARM: dts: imx6ul: Add Variscite storage and wireless files Stefano Radaelli
2026-09-27 11:06 ` sashiko-bot
2026-09-26 11:05 ` [PATCH v2 06/11] ARM: dts: imx6ul: Add Variscite carrier board files Stefano Radaelli
2026-09-27 11:06 ` sashiko-bot
2026-09-26 11:05 ` [PATCH v2 07/11] ARM: dts: imx6ul: Reuse Variscite DTSI files for Concerto Stefano Radaelli
2026-09-27 11:06 ` sashiko-bot
2026-09-26 11:05 ` [PATCH v2 08/11] ARM: dts: imx6ul: Add Variscite i.MX6UL board variants Stefano Radaelli
2026-09-27 11:06 ` sashiko-bot
2026-09-26 11:05 ` [PATCH v2 09/11] ARM: dts: imx6ull: Add Variscite i.MX6ULL " Stefano Radaelli
2026-09-26 11:05 ` [PATCH v2 10/11] ARM: dts: imx6ulz: Add Variscite i.MX6ULZ " Stefano Radaelli
2026-09-27 11:06 ` sashiko-bot [this message]
2026-09-26 11:05 ` [PATCH v2 11/11] ARM: dts: imx6ul: Enable Variscite i.MX6UL board DTBs Stefano Radaelli
2026-09-27 11:06 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260927110622.A71DA1F00898@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=stefano.radaelli21@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox