From: sashiko-bot@kernel.org
To: "Stefano Radaelli" <stefano.radaelli21@gmail.com>
Cc: robh@kernel.org, conor+dt@kernel.org, Frank.Li@kernel.org,
imx@lists.linux.dev, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 11/11] ARM: dts: imx6ul: Enable Variscite i.MX6UL board DTBs
Date: Sun, 27 Sep 2026 11:06:23 +0000 [thread overview]
Message-ID: <20260927110623.8AEC71F000FF@smtp.kernel.org> (raw)
In-Reply-To: <18c922ead3419fbc68e88d3ce1233faa9b1a2e63.1790413032.git.stefano.r@variscite.com>
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] build: Combinatorial explosion of static DTB variants instead of using overlays
- [Low] build: Makefile DTB targets are not sorted alphabetically
--
commit 811039deaa62a10ae4930e5cd0e5773613e884fb
Author: Stefano Radaelli <stefano.r@variscite.com>
Subject: ARM: dts: imx6ul: Enable Variscite i.MX6UL board DTBs
Add Makefile targets for the VAR-SOM-6UL and DART-6UL board variants based
on i.MX6UL, i.MX6ULL and i.MX6ULZ. Keep the existing Concerto DTB targets
enabled alongside the new carrier, storage, wireless and audio combinations.
> diff --git a/arch/arm/boot/dts/nxp/imx/Makefile b/arch/arm/boot/dts/nxp/imx/Makefile
> index c5caca92ea10c..cdca939b10a96 100644
> --- a/arch/arm/boot/dts/nxp/imx/Makefile
> +++ b/arch/arm/boot/dts/nxp/imx/Makefile
> @@ -377,6 +377,36 @@ dtb-$(CONFIG_SOC_IMX6UL) += \
> imx6ul-tx6ul-mainboard.dtb \
> imx6ul-var-som-concerto.dtb \
> imx6ul-var-som-concerto-full.dtb \
> + imx6ul-var-dart-emmc-sd-card-wm8731-6ulcustomboard.dtb \
> + imx6ul-var-dart-emmc-sd-card-6ulcustomboard.dtb \
[Severity: Low]
Do these newly added targets skip strict alphabetical sorting within the
dtb-$(CONFIG_SOC_IMX6UL) Makefile group?
For instance, the dart variants are appended after the som variants, and
longer feature strings with w appear before shorter ones with 6. Could this
increase the likelihood of merge conflicts?
[Severity: Medium]
Does compiling all these base, module, and carrier board variants as distinct
static blobs cause unnecessary bloat to the kernel install and Makefile?
Building the dtbs for i.MX6UL, i.MX6ULL, and i.MX6ULZ currently generates
around 90 distinct static blobs for all the combinations of eMMC/NAND,
SD/WiFi, and audio codecs.
Would it be more aligned with standard upstream practices to provide base dtb
files and build the optional modules as Device Tree Overlays (.dtbo) to be
applied at runtime by the bootloader?
--
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1790413032.git.stefano.r@variscite.com?part=11
prev parent reply other threads:[~2026-09-27 11:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-26 11:05 [PATCH v2 00/11] ARM: dts: imx6ul: Add Variscite VAR-SOM-6UL and DART-6UL Stefano Radaelli
2026-09-26 11:05 ` [PATCH v2 01/11] dt-bindings: arm: fsl: Document Variscite i.MX6UL boards Stefano Radaelli
2026-09-26 11:05 ` [PATCH v2 02/11] dt-bindings: net: micrel: Fix RMII clock select property type Stefano Radaelli
2026-09-26 11:05 ` [PATCH v2 03/11] ARM: dts: imx6ul: Add Variscite SoM and DART base files Stefano Radaelli
2026-09-27 11:06 ` sashiko-bot
2026-09-26 11:05 ` [PATCH v2 04/11] ARM: dts: imx6ul: Add Variscite audio codec files Stefano Radaelli
2026-09-26 11:05 ` [PATCH v2 05/11] ARM: dts: imx6ul: Add Variscite storage and wireless files Stefano Radaelli
2026-09-27 11:06 ` sashiko-bot
2026-09-26 11:05 ` [PATCH v2 06/11] ARM: dts: imx6ul: Add Variscite carrier board files Stefano Radaelli
2026-09-27 11:06 ` sashiko-bot
2026-09-26 11:05 ` [PATCH v2 07/11] ARM: dts: imx6ul: Reuse Variscite DTSI files for Concerto Stefano Radaelli
2026-09-27 11:06 ` sashiko-bot
2026-09-26 11:05 ` [PATCH v2 08/11] ARM: dts: imx6ul: Add Variscite i.MX6UL board variants Stefano Radaelli
2026-09-27 11:06 ` sashiko-bot
2026-09-26 11:05 ` [PATCH v2 09/11] ARM: dts: imx6ull: Add Variscite i.MX6ULL " Stefano Radaelli
2026-09-26 11:05 ` [PATCH v2 10/11] ARM: dts: imx6ulz: Add Variscite i.MX6ULZ " Stefano Radaelli
2026-09-27 11:06 ` sashiko-bot
2026-09-26 11:05 ` [PATCH v2 11/11] ARM: dts: imx6ul: Enable Variscite i.MX6UL board DTBs Stefano Radaelli
2026-09-27 11:06 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260927110623.8AEC71F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=stefano.radaelli21@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox