From: sashiko-bot@kernel.org
To: "Wolfram Sang" <wsa+renesas@sang-engineering.com>
Cc: conor+dt@kernel.org, wsa+renesas@sang-engineering.com,
robh@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: renesas: r8a78000: Add I2C nodes
Date: Sun, 27 Sep 2026 15:22:52 +0000 [thread overview]
Message-ID: <20260927152252.AA5FD1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260927151133.45845-3-wsa+renesas@sang-engineering.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dts: missing prerequisite includes and nodes for i2c controllers
--
commit 3f7801bb0ea0ac6eb4aa58321a3d66e8c5413897
Author: Wolfram Sang <wsa+renesas@sang-engineering.com>
arm64: dts: renesas: r8a78000: Add I2C nodes
Add device nodes for the I2C controllers of the Renesas R-Car X5H (R8A78000)
SoC.
> diff --git a/arch/arm64/boot/dts/renesas/r8a78000.dtsi b/arch/arm64/boot/dts/renesas/r8a78000.dtsi
> index fb71974ef3905..a6a60d8930dec 100644
> --- a/arch/arm64/boot/dts/renesas/r8a78000.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a78000.dtsi
> @@ -877,6 +877,118 @@ gic: interrupt-controller@39000000 {
> interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
> };
>
> + i2c1: i2c@c06c0000 {
> + compatible = "renesas,i2c-r8a78000",
> + "renesas,rcar-gen5-i2c";
> + reg = <0 0xc06c0000 0 0x40>;
> + interrupts = <GIC_SPI 956 IRQ_TYPE_LEVEL_HIGH>;
> + i2c-scl-internal-delay-ns = <110>;
> + clocks = <&cpg R8A78000_CPG_SGASYNCD8_PERW_BUS>;
> + power-domains = <&mdlc_perw R8A78000_MDLC_PD_APL 0x44>;
> + resets = <&mdlc_perw 0x44>;
[Severity: Low]
Will this device tree compile cleanly on the current baseline?
It looks like the R8A78000_CPG_SGASYNCD8_PERW_BUS and R8A78000_MDLC_PD_APL
macros, as well as the &cpg and &mdlc_perw phandles, are not yet defined in
the current tree.
Could this cause syntax errors and unresolved phandle references during the
build?
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260927151133.45845-3-wsa+renesas@sang-engineering.com?part=1
next prev parent reply other threads:[~2026-09-27 15:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-27 15:09 [PATCH] arm64: dts: renesas: r8a78000: Add I2C nodes Wolfram Sang
2026-09-27 15:22 ` sashiko-bot [this message]
2026-09-28 9:11 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260927152252.AA5FD1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox