From: sashiko-bot@kernel.org
To: "Rosen Penev" <rosenp@gmail.com>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] powerpc: dts: eiger: add placeholder reg to ndfc node
Date: Sun, 27 Sep 2026 21:41:09 +0000 [thread overview]
Message-ID: <20260927214110.34B2A1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260927213540.132854-1-rosenp@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] powerpc: dts: reg mismatch in ndfc@1,0 and commit message hallucination
--
commit afb12c63aa6cb278745948eaa45ee1e2d6983ea8
Author: Rosen Penev <rosenp@gmail.com>
powerpc: dts: eiger: add placeholder reg to ndfc node
This commit adds a zeroed reg placeholder to the ndfc node in eiger.dts to
satisfy a new IBM NDFC binding requirement. It claims this matches an
existing placeholder in the nor_flash node.
> Add a zeroed placeholder, as the nor_flash@0,0 node in the same file
> already does.
[Severity: Medium]
Is this statement accurate? Looking at the nor_flash@0,0 node in
arch/powerpc/boot/dts/eiger.dts, there is no zeroed reg placeholder present,
only a comment indicating that the property is supplied by U-Boot:
nor_flash@0,0 {
compatible = "amd,s29gl512n", "cfi-flash";
bank-width = <2>;
/* reg property is supplied in by U-Boot */
> diff --git a/arch/powerpc/boot/dts/eiger.dts b/arch/powerpc/boot/dts/eiger.dts
> index 7a1231d9d6f04..fe7b518dae45d 100644
> --- a/arch/powerpc/boot/dts/eiger.dts
> +++ b/arch/powerpc/boot/dts/eiger.dts
> @@ -196,7 +196,7 @@ partition@3fa0000 {
>
> ndfc@1,0 {
> compatible = "ibm,ndfc";
> - /* reg property is supplied by U-boot */
> + reg = <0x00000000 0x00000000 0x00000000>; /* Filled in by U-Boot */
[Severity: Medium]
Because the node's unit address is @1,0, does the first address cell in the
reg property need to be 0x1 to match? Setting it to 0x0 introduces a
unit_address_vs_reg dtc compiler warning.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260927213540.132854-1-rosenp@gmail.com?part=1
prev parent reply other threads:[~2026-09-27 21:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-27 21:35 [PATCH] powerpc: dts: eiger: add placeholder reg to ndfc node Rosen Penev
2026-09-27 21:41 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260927214110.34B2A1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=rosenp@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox