[PATCH] powerpc: dts: eiger: add placeholder reg to ndfc node

[PATCH] powerpc: dts: eiger: add placeholder reg to ndfc node

[Rosen Penev]

The ndfc node of eiger.dts has no reg property, U-Boot fills it in at
runtime.  The new IBM NDFC binding makes it required, so dtbs_check
now reports

  ndfc@1,0 (ibm,ndfc): 'reg' is a required property

Add a zeroed placeholder, as the nor_flash@0,0 node in the same file
already does.

Assisted-by: LLM
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 arch/powerpc/boot/dts/eiger.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/boot/dts/eiger.dts b/arch/powerpc/boot/dts/eiger.dts
index dc4d74c523ec..7260cdde281a 100644
--- a/arch/powerpc/boot/dts/eiger.dts
+++ b/arch/powerpc/boot/dts/eiger.dts
@@ -196,7 +196,7 @@ partition@3fa0000 {
 
 				ndfc@1,0 {
 					compatible = "ibm,ndfc";
-					/* reg property is supplied by U-boot */
+					reg = <0x00000000 0x00000000 0x00000000>; /* Filled in by U-Boot */
 					ccr = <0x00003000>;
 					bank-settings = <0x80002222>;
 					#address-cells = <1>;
-- 
2.55.0

Re: [PATCH] powerpc: dts: eiger: add placeholder reg to ndfc node

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] powerpc: dts: reg mismatch in ndfc@1,0 and commit message hallucination
--

commit afb12c63aa6cb278745948eaa45ee1e2d6983ea8
Author: Rosen Penev <rosenp@gmail.com>

powerpc: dts: eiger: add placeholder reg to ndfc node

This commit adds a zeroed reg placeholder to the ndfc node in eiger.dts to
satisfy a new IBM NDFC binding requirement. It claims this matches an
existing placeholder in the nor_flash node.

>     Add a zeroed placeholder, as the nor_flash@0,0 node in the same file
>     already does.

[Severity: Medium]
Is this statement accurate? Looking at the nor_flash@0,0 node in
arch/powerpc/boot/dts/eiger.dts, there is no zeroed reg placeholder present,
only a comment indicating that the property is supplied by U-Boot:

				nor_flash@0,0 {
					compatible = "amd,s29gl512n", "cfi-flash";
					bank-width = <2>;
					/* reg property is supplied in by U-Boot */

> diff --git a/arch/powerpc/boot/dts/eiger.dts b/arch/powerpc/boot/dts/eiger.dts
> index 7a1231d9d6f04..fe7b518dae45d 100644
> --- a/arch/powerpc/boot/dts/eiger.dts
> +++ b/arch/powerpc/boot/dts/eiger.dts
> @@ -196,7 +196,7 @@ partition@3fa0000 {
>  
>  				ndfc@1,0 {
>  					compatible = "ibm,ndfc";
> -					/* reg property is supplied by U-boot */
> +					reg = <0x00000000 0x00000000 0x00000000>; /* Filled in by U-Boot */

[Severity: Medium]
Because the node's unit address is @1,0, does the first address cell in the
reg property need to be 0x1 to match? Setting it to 0x0 introduces a
unit_address_vs_reg dtc compiler warning.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260927213540.132854-1-rosenp@gmail.com?part=1