Re: [PATCH v3 09/12] ARM: dts: imx6ul: Add Variscite i.MX6UL board variants

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dts: combinatorial explosion of board DT files instead of overlays
--

commit bc40e2df59f147ba5a7cdb739e68027ac8e36f19
Author: Stefano Radaelli <stefano.r@variscite.com>

ARM: dts: imx6ul: Add Variscite i.MX6UL board variants

This commit adds 30 device tree files for Variscite VAR-SOM-6UL and
DART-6UL boards to support various hardware options. It composes each board
description from shared module, option, and carrier DTSI files.

> diff --git a/arch/arm/boot/dts/nxp/imx/imx6ul-var-dart-emmc-sd-card-6ulcustomboard.dts b/arch/arm/boot/dts/nxp/imx/imx6ul-var-dart-emmc-sd-card-6ulcustomboard.dts
> new file mode 100644
> index 0000000000000..c7c05406bd804
> --- /dev/null
> +++ b/arch/arm/boot/dts/nxp/imx/imx6ul-var-dart-emmc-sd-card-6ulcustomboard.dts
> @@ -0,0 +1,20 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Copyright (C) 2026 Variscite Ltd. - https://www.variscite.com
> + */
> +
> +/dts-v1/;
> +
> +#include "imx6ul.dtsi"
> +#include "imx6ul-var-dart.dtsi"
> +#include "imx6ul-imx6ull-var-emmc.dtsi"
> +#include "imx6ul-imx6ull-var-dart-wm8904.dtsi"
> +#include "imx6ul-var-dart-6ulcustomboard.dtsi"
> +#include "imx6ul-imx6ull-var-dart-6ulcustomboard-sd-card.dtsi"
> +
> +/ {
> +	model = "Variscite DART-6UL with i.MX6UL, eMMC, SD card & WM8904 support on VAR-6ULCustomBoard";
> +	compatible = "variscite,dart-6ul-imx6ul-emmc-sd-card-6ulcustomboard",

[Severity: Low]
Does this approach cause a combinatorial explosion of device tree files?

In arch/arm/boot/dts/nxp/imx/imx6ul-var-dart-emmc-sd-card-6ulcustomboard.dts,
adding 30 boilerplate .dts files to cover every hardware permutation of
carrier board, storage, wireless, and audio options creates a maintainability
burden in the kernel tree. Adding any new optional hardware component will
require exponentially more static files to cover all combinations.

Could this be handled via Device Tree Overlays (.dtso) or dynamic bootloader
fixups rather than creating a full static .dts file for every permutation?

> +		     "variscite,dart-6ul-imx6ul",
> +		     "fsl,imx6ul";
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1790512621.git.stefano.r@variscite.com?part=9