Re: [PATCH v3 10/12] ARM: dts: imx6ull: Add Variscite i.MX6ULL board variants

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dts: imx6ull: mismatch between WIFI_PWR_EN gpio and pinctrl in iw61x
--

commit 7ecb2605fbe6b95010bccb212ceb09c1b978e781
Author: Stefano Radaelli <stefano.r@variscite.com>

ARM: dts: imx6ull: Add Variscite i.MX6ULL board variants
    
Add i.MX6ULL board DTS files for VAR-SOM-6UL and DART-6UL with their
carrier, storage, wireless and audio options.

Reuse the shared option and carrier descriptions with the i.MX6ULL
SoC and module wrappers.

[ ... ]

> diff --git a/arch/arm/boot/dts/nxp/imx/imx6ull-var-dart-emmc-wifi-iw61x-6ulcustomboard.dts b/arch/arm/boot/dts/nxp/imx/imx6ull-var-dart-emmc-wifi-iw61x-6ulcustomboard.dts
> new file mode 100644
> index 0000000000000..26d266d731fb8
> --- /dev/null
> +++ b/arch/arm/boot/dts/nxp/imx/imx6ull-var-dart-emmc-wifi-iw61x-6ulcustomboard.dts
> @@ -0,0 +1,20 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Copyright (C) 2026 Variscite Ltd. - https://www.variscite.com
> + */
> +
> +/dts-v1/;
> +
> +#include "imx6ull.dtsi"
> +#include "imx6ull-var-dart.dtsi"
> +#include "imx6ul-imx6ull-var-emmc.dtsi"
> +#include "imx6ul-imx6ull-var-wifi-iw61x.dtsi"

[Severity: Medium]
Does the combination of these included files create a pinmux conflict that
breaks WiFi power control?

The iw61x WiFi power sequence requests GPIO5_IO02 for WIFI_PWR_EN:

arch/arm/boot/dts/nxp/imx/imx6ul-imx6ull-var-wifi-iw61x.dtsi:iw61x_pwrseq {
		reset-gpios = <&gpio5 6 GPIO_ACTIVE_LOW>, /* WIFI_RESET */
			      <&gpio5 2 GPIO_ACTIVE_LOW>; /* WIFI_PWR_EN */
}

But the associated pinctrl_wifi group in the DART module wrapper configures
GPIO5_IO04 instead of GPIO5_IO02:

arch/arm/boot/dts/nxp/imx/imx6ull-var-dart.dtsi:pinctrl_wifi {
		fsl,pins = <
			MX6ULL_PAD_SNVS_TAMPER4__GPIO5_IO04	0x1b0b0
			MX6ULL_PAD_SNVS_TAMPER6__GPIO5_IO06	0x03029
		>;
}

Because of this mismatch, the requested GPIO5_IO02 is never properly pinmuxed,
and the configured pad is never toggled. Will this cause the IW61x WiFi
module to fail to power on during the usdhc1 probe?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1790512621.git.stefano.r@variscite.com?part=10