Re: [PATCH v17 11/11] arm64: dts: qcom: kaanapali: Add camera MCLK pinctrl

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dts: devicetree node names incorrectly use underscores
--

commit 185a6cf958fbea99362a9e2c9f3989dad4362d3c
Author: Hangxiang Ma <hangxiang.ma@oss.qualcomm.com>

arm64: dts: qcom: kaanapali: Add camera MCLK pinctrl

This commit adds TLMM pinctrl states for the camera master clock GPIOs on
Kaanapali so camera sensor nodes can select the proper MCLK pin functions
when enabled.

> diff --git a/arch/arm64/boot/dts/qcom/kaanapali.dtsi b/arch/arm64/boot/dts/qcom/kaanapali.dtsi
> index c19945bc438eb..bbcd5a622f0b2 100644
> --- a/arch/arm64/boot/dts/qcom/kaanapali.dtsi
> +++ b/arch/arm64/boot/dts/qcom/kaanapali.dtsi
[ ... ]
> +			cam_mclk2_default: cam-mclk2-default-state {
> +				pins = "gpio91";
> +				function = "cam_asc_mclk2";
> +				drive-strength = <2>;
> +				bias-disable;
> +			};
> +
> +			cam_mclk3_default: cam_mclk3-default-state {

[Severity: Low]
Does this node name incorrectly use an underscore instead of a hyphen?

Devicetree node names conventionally use hyphens rather than underscores.
The previous nodes like cam-mclk0-default-state use the correct hyphenated
pattern.

Using an underscore here and in the subsequent cam_mclk4 through cam_mclk7
nodes will trigger dtc style warnings (node_name_chars_strict) and fail
standard devicetree style checks.

> +				pins = "gpio92";
> +				function = "cam_mclk";
> +				drive-strength = <2>;
> +				bias-disable;
> +			};
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260928-kaanapali-camss-v17-0-dcf3fd37f76c@oss.qualcomm.com?part=11