Re: [PATCH v17 02/11] media: dt-bindings: Add CAMSS device for Kaanapali

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] media: dt-bindings: contradictory port count description vs schema
--

commit eaf675a1ac25eea3cc950df0432cfe59f97c1517
Author: Hangxiang Ma <hangxiang.ma@oss.qualcomm.com>

media: dt-bindings: Add CAMSS device for Kaanapali

Add bindings for Camera Subsystem (CAMSS) on the Qualcomm Kaanapali
platform.

> diff --git a/Documentation/devicetree/bindings/media/qcom,kaanapali-camss.yaml b/Documentation/devicetree/bindings/media/qcom,kaanapali-camss.yaml
> new file mode 100644
> index 0000000000000..1f8b18517e13a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/qcom,kaanapali-camss.yaml
[ ... ]
> +  power-domain-names:
> +    items:
> +      - const: ife0
> +      - const: ife1
> +      - const: ife2
> +      - const: top
> +
> +  ports:
> +    $ref: /schemas/graph.yaml#/properties/ports
> +
> +    description:
> +      CSI input ports, one per CSID. Each port receives the CSI data
> +      decoded by the matching CSIPHY.
> +
> +    patternProperties:
> +      "^port@[0-5]$":
> +        $ref: /schemas/graph.yaml#/$defs/port-base
> +        unevaluatedProperties: false
> +        description:
> +          Input port for receiving CSI data from CSIPHY 0-5.

[Severity: Low]
Could this description be updated to clarify the port count?

The commit message indicates the platform has 5 CSIDs (3 regular, 2 lite)
and 6 CSIPHYs. The top-level description for the ports node states there is
"one per CSID", which would imply 5 ports. However, the schema allows 6 ports
("^port@[0-5]$") and the nested description mentions receiving data from
CSIPHY 0-5.

Does the "one per CSID" text need to be updated to match the hardware layout
allowed by the schema?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260928-kaanapali-camss-v17-0-dcf3fd37f76c@oss.qualcomm.com?part=2