Re: [RFC PATCH v3 1/3] dt-bindings: mfd: rk808: add board level power hold GPIOs

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: missing matching updates for RK8xx family schemas
--

commit 93b9eb84ca6a701561f53536db13d8e8300dd8da
Author: Yaozhong Li <yaozhonguwl@gmail.com>

dt-bindings: mfd: rk808: add board level power hold GPIOs

This commit adds power-hold-gpios and power-hold-delay-ms properties to
the rockchip,rk808 binding schema to describe board-level power hold lines
routed from the SoC.

> diff --git a/Documentation/devicetree/bindings/mfd/rockchip,rk808.yaml b/Documentation/devicetree/bindings/mfd/rockchip,rk808.yaml
> --- a/Documentation/devicetree/bindings/mfd/rockchip,rk808.yaml
> +++ b/Documentation/devicetree/bindings/mfd/rockchip,rk808.yaml
> @@ -43,6 +43,24 @@ properties:
>  
>    system-power-controller: true
>  
> +  power-hold-gpios:
> +    minItems: 1
> +    maxItems: 2

[Severity: Medium]
Does this update need to be applied to the other RK8xx family schemas as
well?

The dt-bindings subsystem guidelines state that when a binding has multiple
YAML files for different device types in the same family, related files
must be updated together when adding shared capabilities.

Since this power hold feature is implemented globally for all RK8xx PMICs
in rk8xx-core.c during probe, won't boards using other PMICs in the family
(such as RK805 or RK818) fail schema validation if they attempt to use this
routing feature, as it is only being permitted here in the rk808 schema?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260929140649.55-1-yaozhonguwl@gmail.com?part=1