Devicetree
 help / color / mirror / Atom feed
From: Yaozhong Li <yaozhonguwl@gmail.com>
To: sashiko-reviews@lists.linux.dev
Cc: Lee Jones <lee@kernel.org>, Rob Herring <robh@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	devicetree@vger.kernel.org, mfd@lists.linux.dev,
	Yaozhong Li <yaozhonguwl@gmail.com>
Subject: Re: [RFC PATCH v3 1/3] dt-bindings: mfd: rk808: add board level power hold GPIOs
Date: Wed, 30 Sep 2026 00:27:42 +0800	[thread overview]
Message-ID: <20260929162742.1374-1-yaozhonguwl@gmail.com> (raw)
In-Reply-To: <20260929141534.358FD1F00893@smtp.kernel.org>

On 2026-09-29 14:15 UTC, sashiko-bot@kernel.org wrote:
> Does this update need to be applied to the other RK8xx family schemas
> as well?

Yes, I will change this in v4.

rk8xx_probe() reads power-hold-gpios for every variant that is the
system power controller, and all of rockchip,rk801, rk805, rk806,
rk808, rk816, rk817 and rk818.yaml allow system-power-controller. The
property should therefore be described in all seven. It is not only a
theoretical case: Firefly's own BSP uses both pmic,stby-gpio and
pmic,hold-gpio with an RK818 on the RK3128-based FirePrime.

v4 will add power-hold-gpios and power-hold-delay-ms to all seven
schemas, each with the dependency on whichever spelling of
system-power-controller that schema accepts.

Thanks,
Yaozhong

  reply	other threads:[~2026-09-29 16:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-29 14:06 [RFC PATCH v3 0/3] Fix poweroff restarting the board on Firefly-RK3399 Yaozhong Li
2026-09-29 14:06 ` [RFC PATCH v3 1/3] dt-bindings: mfd: rk808: add board level power hold GPIOs Yaozhong Li
2026-09-29 14:15   ` sashiko-bot
2026-09-29 16:27     ` Yaozhong Li [this message]
2026-09-29 14:06 ` [RFC PATCH v3 2/3] mfd: rk8xx: Release the power hold GPIOs before powering off Yaozhong Li
2026-09-29 14:13   ` sashiko-bot
2026-09-29 14:06 ` [RFC PATCH v3 3/3] arm64: dts: rockchip: fix power-off on Firefly-RK3399 Yaozhong Li
2026-09-29 14:13   ` sashiko-bot
2026-09-29 16:27     ` Yaozhong Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260929162742.1374-1-yaozhonguwl@gmail.com \
    --to=yaozhonguwl@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lee@kernel.org \
    --cc=mfd@lists.linux.dev \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox