Re: [PATCH v2 5/5] arm64: dts: qcom: maili: Add base MTP board

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] dts: qcom: maili: Swapped vdda-phy and vdda-pll supplies for usb_dp_qmpphy
--

commit 52dffe9df955d99886bd7c5b77879c715dff5003
Author: Jingyi Wang <jingyi.wang@oss.qualcomm.com>

arm64: dts: qcom: maili: Add base MTP board

This commit adds initial device tree support for the Qualcomm Maili MTP board. 
It enables booting to shell with UART console and configures features such as 
UFS, remoteprocs, USB, PCIe, SD Card, and PMICs.

> diff --git a/arch/arm64/boot/dts/qcom/maili-mtp.dts b/arch/arm64/boot/dts/qcom/maili-mtp.dts
> new file mode 100644
> index 0000000000000..1fdc91e03271c
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/maili-mtp.dts

[ ... ]

> +&usb_dp_qmpphy {
> +	vdda-phy-supply = <&vreg_l3g_1p2>;
> +	vdda-pll-supply = <&vreg_l3i_0p9>;

[Severity: High]
Are the regulator assignments for vdda-phy-supply and vdda-pll-supply inverted
here?

The vdda-phy-supply is assigned a 1.2V regulator (vreg_l3g_1p2), and the
vdda-pll-supply is assigned a 0.9V regulator (vreg_l3i_0p9). Providing 1.2V
to the core PHY logic might cause over-voltage hardware stress or damage.
Conversely, providing 0.9V to the PLL could result in an under-voltage
condition that prevents the PLL from locking during initialization.

Could you confirm if these regulators should be swapped to supply 0.9V to the
PHY and 1.2V to the PLL?

> +
> +	status = "okay";
> +};

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260929-maili-dts-v2-0-965688646c4b@oss.qualcomm.com?part=5