Re: [PATCH v4 3/4] arm64: dts: arduino-imola: add support for sound

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] ASoC: qrb2210-sndcard: duplicate BE DAI links for RX_CODEC_DMA_RX_0
--

commit d222aeffc646b4d2645c81200f3c926432d5d57b
Author: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>

arm64: dts: arduino-imola: add support for sound

This commit adds sound support for the Arduino UNO Q board, enabling headset
playback and record, lineout, and ear out functionalities. It updates the
pm4125 device tree include and introduces audio routing and DAI links in the
arduino-imola device tree.

> diff --git a/arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts b/arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts
> index c472e13fceca4..e99d2a56dc287 100644
> --- a/arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts
> +++ b/arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts
[ ... ]
> +		ear-playback-dai-link {
> +			link-name = "Ear Out Playback";
> +
> +			codec {
> +				sound-dai = <&pmic4125_codec 0>, <&swr1 0>, <&rxmacro 0>;
> +			};
> +
> +			cpu {
> +				sound-dai = <&q6afedai RX_CODEC_DMA_RX_0>;
> +			};
[ ... ]
> +		hph-playback-dai-link {
> +			link-name = "Headphones Playback";
> +
> +			codec {
> +				sound-dai = <&pmic4125_codec 0>, <&swr1 0>, <&rxmacro 0>;
> +			};
> +
> +			cpu {
> +				sound-dai = <&q6afedai RX_CODEC_DMA_RX_0>;
> +			};
[ ... ]
> +		lo-playback-dai-link {
> +			link-name = "Line Out Playback";
> +
> +			codec {
> +				sound-dai = <&pmic4125_codec 0>, <&swr1 0>, <&rxmacro 0>;
> +			};
> +
> +			cpu {
> +				sound-dai = <&q6afedai RX_CODEC_DMA_RX_0>;
> +			};

[Severity: Low]
Are we creating redundant backend DAI links for the exact same physical CPU
DAI (RX_CODEC_DMA_RX_0) here?

In ASoC DPCM, dpcm_get_be() returns only the first RTD it matches for a given
widget. Because of this, it appears DPCM will strictly only use the 
ear-playback-dai-link, while the hph-playback-dai-link and 
lo-playback-dai-link will be ignored and their hardware operations will 
never execute concurrently.

Could these be consolidated into a single backend DAI link, relying on the
pm4125 codec's internal DAPM graph to handle multiplexing the single backend
stream to the Ear, Headphone, and Lineout pins?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260930124607.1109167-1-srinivas.kandagatla@oss.qualcomm.com?part=3