From: sashiko-bot@kernel.org
To: "Srinivas Kandagatla" <srinivas.kandagatla@oss.qualcomm.com>
Cc: mfd@lists.linux.dev, lee@kernel.org, devicetree@vger.kernel.org,
conor+dt@kernel.org, robh@kernel.org
Subject: Re: [PATCH v4 1/4] dt-bindings: mfd: qcom,spmi-pmic: add compatibles for pm4125-codec
Date: Wed, 30 Sep 2026 12:51:39 +0000 [thread overview]
Message-ID: <20260930125140.3EF941F00899@smtp.kernel.org> (raw)
In-Reply-To: <20260930124607.1109167-2-srinivas.kandagatla@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] mfd: commit message description is not capitalized
--
commit 0fe10ec995802f796e4bfb33e8867d9a4a028323
Author: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
dt-bindings: mfd: qcom,spmi-pmic: add compatibles for pm4125-codec
This commit adds the missing qcom,pm4125-codec compatible to the audio-codec
node properties in the qcom,spmi-pmic schema to complete support for the
PM4125 PMIC.
> dt-bindings: mfd: qcom,spmi-pmic: add compatibles for pm4125-codec
[Severity: Low]
This isn't a bug, but does this violate the MFD subsystem commit message
formatting guidelines? The description after the prefix should be
capitalized, but "add" uses a lowercase "a".
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260930124607.1109167-1-srinivas.kandagatla@oss.qualcomm.com?part=1
next prev parent reply other threads:[~2026-09-30 12:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 12:46 [PATCH v4 0/4] arm64: dts: arduino-imola: add support for sound Srinivas Kandagatla
2026-09-30 12:46 ` [PATCH v4 1/4] dt-bindings: mfd: qcom,spmi-pmic: add compatibles for pm4125-codec Srinivas Kandagatla
2026-09-30 12:51 ` sashiko-bot [this message]
2026-10-02 6:07 ` Krzysztof Kozlowski
2026-09-30 12:46 ` [PATCH v4 2/4] arm64: dts: qcom: agatti: add LPASS devices Srinivas Kandagatla
2026-09-30 12:56 ` sashiko-bot
2026-09-30 12:46 ` [PATCH v4 3/4] arm64: dts: arduino-imola: add support for sound Srinivas Kandagatla
2026-09-30 13:01 ` sashiko-bot
2026-09-30 12:46 ` [PATCH v4 4/4] arm64: defconfig: Enable pm4125 audio codec driver Srinivas Kandagatla
2026-09-30 12:49 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260930125140.3EF941F00899@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lee@kernel.org \
--cc=mfd@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=srinivas.kandagatla@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox