Re: [PATCH v2 2/3] dt-bindings: sound: tegra-ahub: Convert to json-schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: schema bypass for tegra132 due to const instead of contains
--

commit cc353b75e1127a04e8bb3722f63443c9ec2f2daf
Author: Thierry Reding <treding@nvidia.com>

dt-bindings: sound: tegra-ahub: Convert to json-schema
    
Convert Tegra AHUB bindings from the free-form text format to
json-schema.

> diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra30-ahub.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra30-ahub.yaml
> new file mode 100644
> index 0000000000000..4a7f5c74125c2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra30-ahub.yaml
> @@ -0,0 +1,288 @@
[ ... ]
> +properties:
> +  compatible:
> +    oneOf:
> +      - const: nvidia,tegra30-ahub
> +      - const: nvidia,tegra114-ahub
> +      - const: nvidia,tegra124-ahub
> +      - items:
> +          - const: nvidia,tegra132-ahub
> +          - const: nvidia,tegra124-ahub
[ ... ]
> +  - if:
> +      properties:
> +        compatible:
> +          const: nvidia,tegra124-ahub

[Severity: Medium]
Will this exact match condition fail when evaluated against the tegra132
compatible sequence array?

Since JSON Schema const requires exact equality, this condition evaluates to
false when checking the device tree array ["nvidia,tegra132-ahub",
"nvidia,tegra124-ahub"].

This causes hardware constraints (such as reg, resets, and dmas properties
requirements) defined for tegra124-ahub to be silently skipped for
tegra132-ahub device tree nodes, allowing incomplete configurations to pass
schema validation.

Should this use contains: enum: or contains: const: instead of const:
to correctly match fallback sequences?

> +    then:
> +      properties:
> +        reg:
> +          items:
> +            - description: APBIF registers

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260930-as3722-bindings-v2-0-a3bba649ebf9@nvidia.com?part=2