Re: [PATCH v3 01/15] dt-bindings: iio: adc: stm32-adc: add support for stm32mp23 and stm32mp25

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: channel 19 restriction bypassed via valid hex unit address
--

commit d2461d12172d54981aff89ddbc3a421fb6e6897e
Author: Fabrice Gasnier <fabrice.gasnier@foss.st.com>

dt-bindings: iio: adc: stm32-adc: add support for stm32mp23 and stm32mp25

Adds support for the STM32MP23 and STM32MP25 ADCs by introducing new
compatibles and block configurations. Includes power domain support and
restricts deprecated properties. Also attempts to restrict channel 19
which is wired directly to Vref+ and shouldn't have direct measurement.

> diff --git a/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.yaml b/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.yaml
> --- a/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.yaml

[ ... ]

> @@ -486,6 +524,39 @@ patternProperties:
>                maxItems: 19
>                items:
>                  minimum: 40
> +
> +      - if:
> +          properties:
> +            compatible:
> +              contains:
> +                enum:
> +                  - st,stm32mp23-adc1
> +                  - st,stm32mp23-adc2
> +                  - st,stm32mp23-adc3
> +                  - st,stm32mp25-adc1
> +                  - st,stm32mp25-adc2
> +                  - st,stm32mp25-adc3
> +
> +        then:
> +          properties:

[ ... ]

> +            assigned-resolution-bits:
> +              enum: [6, 8, 10, 12]
> +              default: 12
> +
> +            channel@19: false

[Severity: Medium]
Does this correctly restrict channel 19 if device tree unit addresses are
supposed to be written in hexadecimal?

Because channel 19 would be configured as "channel@13 { reg = <19>; }",
matching against the literal string "channel@19" only blocks an improperly
formatted decimal node name. 

Would this leave the correctly formatted "channel@13" bypass open without
triggering schema validation errors?

> +            st,adc-channels: false
> +            st,adc-diff-channels: false
> +            st,min-sample-time-nsecs: false
> +
>      additionalProperties: false

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260930-adc-stm32mp25-v1-v3-0-406834430d72@foss.st.com?part=1