Re: [PATCH v3 09/15] iio: adc: stm32-adc: add support for stm32mp23

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] iio: adc: missing const qualifier on trigger arrays
--

commit e6098517cec9404a97ce36281256eb9d77667464
Author: Fabrice Gasnier <fabrice.gasnier@foss.st.com>

iio: adc: stm32-adc: add support for stm32mp23
    
Add support for ADC on the STM32MP23 SoC, which has 3 ADCs split into two
blocks. The STM32MP23 trigger list is handled with dedicated compatible data
due to differences from the STM32MP25.

> diff --git a/drivers/iio/adc/stm32-adc.c b/drivers/iio/adc/stm32-adc.c
> index 33e41505b2e99..210b76b21d13b 100644
> --- a/drivers/iio/adc/stm32-adc.c
> +++ b/drivers/iio/adc/stm32-adc.c

[ ... ]

> @@ -563,6 +563,64 @@ static const struct stm32_adc_regspec stm32h7_adc_regspec = {
>  	.smp_bits = stm32h7_smp_bits,
>  };
>  
> +/* STM32MP23 external trigger sources for ADC1 and ADC2 */
> +static struct stm32_adc_trig_info stm32mp23_adc1_adc2_trigs[] = {

[Severity: Low]
Should this array be declared as const? The trigs field in struct
stm32_adc_cfg expects a const struct stm32_adc_trig_info *.

> +	{ TIM1_TRGO, STM32_EXT0 },
> +	{ TIM1_TRGO2, STM32_EXT1 },
> +	{ TIM8_TRGO, STM32_EXT2 },

[ ... ]

> +	{ LPTIM4_CH1, STM32_EXT27 },
> +	{ LPTIM5_OUT, STM32_EXT28 },
> +	{ }
> +};
> +
> +/* STM32MP23 external trigger sources for ADC3 */
> +static struct stm32_adc_trig_info stm32mp23_adc3_trigs[] = {

[Severity: Low]
Does this array also need a const qualifier?

> +	{ TIM1_TRGO, STM32_EXT0 },
> +	{ TIM1_TRGO2, STM32_EXT1 },
> +	{ TIM8_TRGO, STM32_EXT2 },

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260930-adc-stm32mp25-v1-v3-0-406834430d72@foss.st.com?part=9