From: sashiko-bot@kernel.org
To: "Beleswar Padhi" <b-padhi@ti.com>
Cc: robh@kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: mailbox: ti,secure-proxy: Add TDA54 variant compatible
Date: Wed, 30 Sep 2026 17:42:05 +0000 [thread overview]
Message-ID: <20260930174206.428061F00899@smtp.kernel.org> (raw)
In-Reply-To: <20260930172948.2901336-2-b-padhi@ti.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: mailbox: ti,secure-proxy: interrupt maxItems limits TDA54 threads
--
commit 462da78495412d18a7d7ecfb35e5147704655806
Author: Beleswar Padhi <b-padhi@ti.com>
dt-bindings: mailbox: ti,secure-proxy: Add TDA54 variant compatible
This commit adds the ti,tda54-main-secure-proxy compatible to the Texas
Instruments secure proxy mailbox controller binding. The new TDA54 variant
features up to 444 threads with 60-byte messages per thread.
> diff --git a/Documentation/devicetree/bindings/mailbox/ti,secure-proxy.yaml b/Documentation/devicetree/bindings/mailbox/ti,secure-proxy.yaml
> index c321b69f0ccd3..525266953c974 100644
> --- a/Documentation/devicetree/bindings/mailbox/ti,secure-proxy.yaml
> +++ b/Documentation/devicetree/bindings/mailbox/ti,secure-proxy.yaml
> @@ -22,7 +22,9 @@ properties:
> pattern: "^mailbox@[0-9a-f]+$"
>
> compatible:
> - const: ti,am654-secure-proxy
> + enum:
> + - ti,am654-secure-proxy
> + - ti,tda54-main-secure-proxy
[Severity: Low]
Does the addition of this compatible require updating the maximum number of
allowed interrupts in the schema?
The commit message notes that the TDA54 hardware supports up to 444 threads.
However, the existing properties limit both interrupts and interrupt-names
to a maximum of 100 items:
interrupt-names:
minItems: 1
maxItems: 100
interrupts:
minItems: 1
maxItems: 100
If a device tree for the new variant specifies more than 100 receive
interrupts, won't it fail schema validation?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260930172948.2901336-1-b-padhi@ti.com?part=1
next prev parent reply other threads:[~2026-09-30 17:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 17:29 [PATCH 0/2] Add support for TDA54 variant secproxy controllers Beleswar Padhi
2026-09-30 17:29 ` [PATCH 1/2] dt-bindings: mailbox: ti,secure-proxy: Add TDA54 variant compatible Beleswar Padhi
2026-09-30 17:42 ` sashiko-bot [this message]
2026-10-01 5:52 ` Padhi, Beleswar
2026-09-30 21:17 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260930174206.428061F00899@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=b-padhi@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox