Re: [PATCH 1/2] dt-bindings: mailbox: ti,secure-proxy: Add TDA54 variant compatible

["Padhi, Beleswar" <b-padhi@ti.com>]

On 9/30/2026 11:12 PM, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] dt-bindings: mailbox: ti,secure-proxy: interrupt maxItems limits TDA54 threads
> --
>
> commit 462da78495412d18a7d7ecfb35e5147704655806
> Author: Beleswar Padhi <b-padhi@ti.com>
>
> dt-bindings: mailbox: ti,secure-proxy: Add TDA54 variant compatible
>
> This commit adds the ti,tda54-main-secure-proxy compatible to the Texas
> Instruments secure proxy mailbox controller binding. The new TDA54 variant
> features up to 444 threads with 60-byte messages per thread.
>
>> diff --git a/Documentation/devicetree/bindings/mailbox/ti,secure-proxy.yaml b/Documentation/devicetree/bindings/mailbox/ti,secure-proxy.yaml
>> index c321b69f0ccd3..525266953c974 100644
>> --- a/Documentation/devicetree/bindings/mailbox/ti,secure-proxy.yaml
>> +++ b/Documentation/devicetree/bindings/mailbox/ti,secure-proxy.yaml
>> @@ -22,7 +22,9 @@ properties:
>>       pattern: "^mailbox@[0-9a-f]+$"
>>   
>>     compatible:
>> -    const: ti,am654-secure-proxy
>> +    enum:
>> +      - ti,am654-secure-proxy
>> +      - ti,tda54-main-secure-proxy
> [Severity: Low]
> Does the addition of this compatible require updating the maximum number of
> allowed interrupts in the schema?


No.

>
> The commit message notes that the TDA54 hardware supports up to 444 threads.
> However, the existing properties limit both interrupts and interrupt-names
> to a maximum of 100 items:


The hardware has 444 threads for different clients. Linux/HLOS being 1 
client uses
1 thread and therefore 1 interrupt.

>
>    interrupt-names:
>      minItems: 1
>      maxItems: 100
>
>    interrupts:
>      minItems: 1
>      maxItems: 100
>
> If a device tree for the new variant specifies more than 100 receive
> interrupts, won't it fail schema validation?


Not going to happen.

Thanks,
Beleswar