[PATCH 0/2] Add support for TDA54 variant secproxy controllers

[PATCH 0/2] Add support for TDA54 variant secproxy controllers

[Beleswar Padhi]

Add support for the secure proxy mailbox controller integrated in the
MAIN voltage domain of the TI TDA54 SoC, which features up to 444
threads with 60-byte messages per thread.

Add a new compatible in dt-bindings and add the device data in the
ti-msgmgr mbox driver for the same.

Testing done:
 - Build and Boot tested on TI K2 and K3 platforms.
 - Tested that these patches do not generate new warnings or errors.

Test logs:
https://gist.github.com/3V3RYONE/8cb2e49ddd902180a920730b7a5c8016

Cc: Jassi Brar <jassisinghbrar@gmail.com>
Cc: Rob Herring <robh@kernel.org>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: Nishanth Menon <nm@ti.com>
Cc: linux-kernel@vger.kernel.org
Cc: devicetree@vger.kernel.org

Thanks,
Beleswar

Beleswar Padhi (2):
  dt-bindings: mailbox: ti,secure-proxy: Add TDA54 variant compatible
  mailbox: ti-msgmgr: Add ti,tda54-main-secure-proxy support

 .../bindings/mailbox/ti,secure-proxy.yaml     |  4 ++-
 drivers/mailbox/ti-msgmgr.c                   | 33 +++++++++++++++----
 2 files changed, 29 insertions(+), 8 deletions(-)

-- 
2.34.1

[PATCH 1/2] dt-bindings: mailbox: ti,secure-proxy: Add TDA54 variant compatible

[Beleswar Padhi]

Add the ti,tda54-main-secure-proxy compatible for the secure proxy
mailbox controller integrated in the MAIN voltage domain of the TI TDA54
SoC, which features up to 444 threads with 60-byte messages per
thread.

The number of threads is fixed at SoC integration and cannot be
discovered at runtime, therefore a separate compatible is needed.

Signed-off-by: Beleswar Padhi <b-padhi@ti.com>
---
Cc: Jassi Brar <jassisinghbrar@gmail.com>
Cc: Rob Herring <robh@kernel.org>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: Nishanth Menon <nm@ti.com>
Cc: linux-kernel@vger.kernel.org
Cc: devicetree@vger.kernel.org

 .../devicetree/bindings/mailbox/ti,secure-proxy.yaml          | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/mailbox/ti,secure-proxy.yaml b/Documentation/devicetree/bindings/mailbox/ti,secure-proxy.yaml
index c321b69f0ccd3..525266953c974 100644
--- a/Documentation/devicetree/bindings/mailbox/ti,secure-proxy.yaml
+++ b/Documentation/devicetree/bindings/mailbox/ti,secure-proxy.yaml
@@ -22,7 +22,9 @@ properties:
     pattern: "^mailbox@[0-9a-f]+$"
 
   compatible:
-    const: ti,am654-secure-proxy
+    enum:
+      - ti,am654-secure-proxy
+      - ti,tda54-main-secure-proxy
 
   "#mbox-cells":
     const: 1
-- 
2.34.1

Re: [PATCH 1/2] dt-bindings: mailbox: ti,secure-proxy: Add TDA54 variant compatible

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: mailbox: ti,secure-proxy: interrupt maxItems limits TDA54 threads
--

commit 462da78495412d18a7d7ecfb35e5147704655806
Author: Beleswar Padhi <b-padhi@ti.com>

dt-bindings: mailbox: ti,secure-proxy: Add TDA54 variant compatible

This commit adds the ti,tda54-main-secure-proxy compatible to the Texas
Instruments secure proxy mailbox controller binding. The new TDA54 variant
features up to 444 threads with 60-byte messages per thread.

> diff --git a/Documentation/devicetree/bindings/mailbox/ti,secure-proxy.yaml b/Documentation/devicetree/bindings/mailbox/ti,secure-proxy.yaml
> index c321b69f0ccd3..525266953c974 100644
> --- a/Documentation/devicetree/bindings/mailbox/ti,secure-proxy.yaml
> +++ b/Documentation/devicetree/bindings/mailbox/ti,secure-proxy.yaml
> @@ -22,7 +22,9 @@ properties:
>      pattern: "^mailbox@[0-9a-f]+$"
>  
>    compatible:
> -    const: ti,am654-secure-proxy
> +    enum:
> +      - ti,am654-secure-proxy
> +      - ti,tda54-main-secure-proxy

[Severity: Low]
Does the addition of this compatible require updating the maximum number of
allowed interrupts in the schema?

The commit message notes that the TDA54 hardware supports up to 444 threads.
However, the existing properties limit both interrupts and interrupt-names
to a maximum of 100 items:

  interrupt-names:
    minItems: 1
    maxItems: 100

  interrupts:
    minItems: 1
    maxItems: 100

If a device tree for the new variant specifies more than 100 receive
interrupts, won't it fail schema validation?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260930172948.2901336-1-b-padhi@ti.com?part=1

Re: [PATCH 1/2] dt-bindings: mailbox: ti,secure-proxy: Add TDA54 variant compatible

[Padhi, Beleswar]

On 9/30/2026 11:12 PM, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] dt-bindings: mailbox: ti,secure-proxy: interrupt maxItems limits TDA54 threads
> --
>
> commit 462da78495412d18a7d7ecfb35e5147704655806
> Author: Beleswar Padhi <b-padhi@ti.com>
>
> dt-bindings: mailbox: ti,secure-proxy: Add TDA54 variant compatible
>
> This commit adds the ti,tda54-main-secure-proxy compatible to the Texas
> Instruments secure proxy mailbox controller binding. The new TDA54 variant
> features up to 444 threads with 60-byte messages per thread.
>
>> diff --git a/Documentation/devicetree/bindings/mailbox/ti,secure-proxy.yaml b/Documentation/devicetree/bindings/mailbox/ti,secure-proxy.yaml
>> index c321b69f0ccd3..525266953c974 100644
>> --- a/Documentation/devicetree/bindings/mailbox/ti,secure-proxy.yaml
>> +++ b/Documentation/devicetree/bindings/mailbox/ti,secure-proxy.yaml
>> @@ -22,7 +22,9 @@ properties:
>>       pattern: "^mailbox@[0-9a-f]+$"
>>   
>>     compatible:
>> -    const: ti,am654-secure-proxy
>> +    enum:
>> +      - ti,am654-secure-proxy
>> +      - ti,tda54-main-secure-proxy
> [Severity: Low]
> Does the addition of this compatible require updating the maximum number of
> allowed interrupts in the schema?


No.

>
> The commit message notes that the TDA54 hardware supports up to 444 threads.
> However, the existing properties limit both interrupts and interrupt-names
> to a maximum of 100 items:


The hardware has 444 threads for different clients. Linux/HLOS being 1 
client uses
1 thread and therefore 1 interrupt.

>
>    interrupt-names:
>      minItems: 1
>      maxItems: 100
>
>    interrupts:
>      minItems: 1
>      maxItems: 100
>
> If a device tree for the new variant specifies more than 100 receive
> interrupts, won't it fail schema validation?


Not going to happen.

Thanks,
Beleswar

Re: [PATCH 1/2] dt-bindings: mailbox: ti,secure-proxy: Add TDA54 variant compatible

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 75 bytes --]

Acked-by: Conor Dooley <conor.dooley@microchip.com>
pw-bot: not-applicable

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]