Re: [PATCH v5 2/2] arm64: dts: rockchip: add ALIENTEK QuarkPi-CA2

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] dts: gmac1 configuration contradicts commit message regarding RGMII delays
- [Medium] dts: invalid parallel DAPM routing for headphones bypasses the amplifier
--

commit 797f222a3f5a732b55c8373821ac94a17d7cec1f
Author: BG9OXA <bg9oxa@163.com>

arm64: dts: rockchip: add ALIENTEK QuarkPi-CA2

This commit adds device tree support for the ALIENTEK QuarkPi-CA2 single
board computer, defining hardware interfaces including Gigabit Ethernet, USB,
HDMI, PCIe, and an ES8388 audio codec with a headphone amplifier.

> diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-quarkpi-ca2.dts b/arch/arm64/boot/dts/rockchip/rk3588s-quarkpi-ca2.dts
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3588s-quarkpi-ca2.dts

[ ... ]

> +&gmac1 {
> +	phy-mode = "rgmii-id";
> +	clock_in_out = "input";

[Severity: Medium]
The commit message states that the RK3588S RGMII delays are applied on the
MAC side using the tx_delay property. However, this node configures the PHY
to apply delays internally via rgmii-id and lacks a tx_delay property.

Does this configuration inadvertently apply delays on the PHY side instead? If
the MAC driver uses a non-zero default delay when the property is missing,
could the TX delay be applied twice, potentially breaking Gigabit Ethernet
transmission?

[ ... ]

> +	analog_sound: analog-sound {
> +		compatible = "simple-audio-card";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&hp_det &hp_con>;
> +		simple-audio-card,name = "QuarkPi-CA2 ES8388";
> +		simple-audio-card,format = "i2s";
> +		simple-audio-card,bitclock-master = <&sound_cpu>;
> +		simple-audio-card,frame-master = <&sound_cpu>;
> +		simple-audio-card,mclk-fs = <256>;
> +		simple-audio-card,aux-devs = <&hp_amp>;
> +		simple-audio-card,hp-det-gpios = <&gpio1 RK_PC4 GPIO_ACTIVE_HIGH>;
> +		simple-audio-card,pin-switches = "Headphones";
> +		simple-audio-card,widgets =
> +			"Headphone", "Headphones",
> +			"Microphone", "Headset Mic",
> +			"Microphone", "Main Mic";
> +		simple-audio-card,routing =
> +			"Headphones", "LOUT1",
> +			"Headphones", "ROUT1",
> +			"Headphones", "Headphone Power OUTL",
> +			"Headphones", "Headphone Power OUTR",

[Severity: Medium]
The ALSA DAPM routing defines parallel direct paths from the codec (LOUT1 and
ROUT1) to the Headphones widget, alongside the paths passing through the
headphone amplifier (Headphone Power OUTL and OUTR).

Could this parallel direct routing bypass the amplifier logically and confuse
DAPM power management into leaving the external amplifier powered down? DAPM
might see a complete, active path directly from the codec to the headphones,
which could result in no or distorted audio output.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261001-b4-quarkpi-ca2-v5-0-e19296802978@163.com?part=2